3d: make --makefile honor --save_hashes#287
Open
tahina-pro wants to merge 4 commits into
Open
Conversation
Add a new MicroStepSaveHashes micro step and a corresponding Makefile rule so that when --makefile and --save_hashes are both specified, the generated Makefile includes rules to produce <Module>.json hash files. Each hash rule depends on the .3d source file and all produced C/H files for the module (Modul.c, Modul.h, and optionally ModulWrapper.c, ModulWrapper.h, ModulStaticAssertions.c), mirroring what Batch.hashed_files reads when computing hashes in --batch mode. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ck_hashes Test that the generated Makefile produces .json hash files via the new --__micro_step save_hashes, and that --check_hashes strong validates them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a second .3d module (Test2) to exercise --makefile + --save_hashes with multiple modules, ensuring each gets its own .json hash file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When --save_hashes is used with --makefile, the generated Makefile now
includes an EVERPARSE_ALL_JSON_FILES variable listing all .json hash
files, consistent with the existing EVERPARSE_ALL_{H,C,O}_FILES.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @nikswamy for reporting!
So far
--save_hasheshas worked only in default mode, not in Makefile generation mode (--makefile).This PR adds support for
--save_hashesin Makefile generation mode: it adds a--micro_stepto generate the .json file to record the hashes and makes GenMakefile add a rule to generate that .json file.