Skip to content

fix(env): Remove deprecated auto-gomaxprocs flag #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoloJacobs wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −23
Open

fix(env): Remove deprecated auto-gomaxprocs flag #5251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cmd/alertmanager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,6 @@ func run() int {
}
}

if ff.EnableAutoGOMAXPROCS() {
logger.Warn("automaxprocs", "msg", "This flag is deprecated and will be removed in the next release")
}

err = os.MkdirAll(*dataDir, 0o777)
if err != nil {
logger.Error("Unable to create data directory", "err", err)
Expand Down
19 changes: 0 additions & 19 deletions featurecontrol/featurecontrol.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const (
FeatureClassicMode = "classic-mode"
FeatureUTF8StrictMode = "utf8-strict-mode"
FeatureAutoGOMEMLIMIT = "auto-gomemlimit"
FeatureAutoGOMAXPROCS = "auto-gomaxprocs"
FeatureEventRecorder = "event-recorder"
)

Expand All @@ -38,7 +37,6 @@ var AllowedFlags = []string{
FeatureClassicMode,
FeatureUTF8StrictMode,
FeatureAutoGOMEMLIMIT,
FeatureAutoGOMAXPROCS,
FeatureEventRecorder,
}

Expand All @@ -49,7 +47,6 @@ type Flagger interface {
ClassicMode() bool
UTF8StrictMode() bool
EnableAutoGOMEMLIMIT() bool
EnableAutoGOMAXPROCS() bool
EnableEventRecorder() bool
}

Expand All @@ -61,7 +58,6 @@ type Flags struct {
classicMode bool
utf8StrictMode bool
enableAutoGOMEMLIMIT bool
enableAutoGOMAXPROCS bool
enableEventRecorder bool
}

Expand Down Expand Up @@ -89,10 +85,6 @@ func (f *Flags) EnableAutoGOMEMLIMIT() bool {
return f.enableAutoGOMEMLIMIT
}

func (f *Flags) EnableAutoGOMAXPROCS() bool {
return f.enableAutoGOMAXPROCS
}

func (f *Flags) EnableEventRecorder() bool {
return f.enableEventRecorder
}
Expand Down Expand Up @@ -129,12 +121,6 @@ func enableAutoGOMEMLIMIT() flagOption {
}
}

func enableAutoGOMAXPROCS() flagOption {
return func(configs *Flags) {
configs.enableAutoGOMAXPROCS = true
}
}

func enableEventRecorder() flagOption {
return func(configs *Flags) {
configs.enableEventRecorder = true
Expand Down Expand Up @@ -175,9 +161,6 @@ func NewFlags(logger *slog.Logger, features string) (Flagger, error) {
case FeatureAutoGOMEMLIMIT:
opts = append(opts, enableAutoGOMEMLIMIT())
logger.Warn("Automatically set GOMEMLIMIT to match the Linux container or system memory limit.")
case FeatureAutoGOMAXPROCS:
opts = append(opts, enableAutoGOMAXPROCS())
logger.Error("Deprecated: auto-gomaxprocs will be removed in v0.33. Removing this flag does not affect behavior, as Go 1.25+ natively handles container CPU quotas.")
case FeatureEventRecorder:
opts = append(opts, enableEventRecorder())
logger.Warn("Experimental event recorder enabled")
Expand Down Expand Up @@ -211,6 +194,4 @@ func (n NoopFlags) UTF8StrictMode() bool { return false }

func (n NoopFlags) EnableAutoGOMEMLIMIT() bool { return false }

func (n NoopFlags) EnableAutoGOMAXPROCS() bool { return false }

func (n NoopFlags) EnableEventRecorder() bool { return false }
Loading