feat: implement gauge and counter support for OpenMetrics 2.0#894
Open
dashpole wants to merge 2 commits intoprometheus:mainfrom
Open
feat: implement gauge and counter support for OpenMetrics 2.0#894dashpole wants to merge 2 commits intoprometheus:mainfrom
dashpole wants to merge 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: David Ashpole <dashpole@google.com>
bwplotka
reviewed
Apr 7, 2026
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
For common, given v0 I would just comment on the method. If we want to be fancy we can generate comment in the exposition format too (:
Looks good so far, good start (see comments) - only question is do we iterate on this on main or some feature branch - no strong opinion, assuming commentary is clear.
Thanks
Signed-off-by: David Ashpole <dashpole@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #893
Histograms and summaries are left for follow-ups.
Open Questions:
@ywwg @bwplotka @krajorama