textfile: support UTF-8 metric and label names#3729
Open
U-S-jun wants to merge 1 commit into
Open
Conversation
Signed-off-by: USJUN <u.s.junn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #3405 updated
prometheus/commonto v0.66.1 and adapted the textfile parser to its explicit validation API, the parser has usedLegacyValidation. This rejects quoted metric and label names that are valid under the current UTF-8 exposition format, including names containing dots.Use
UTF8Validationwhen parsing textfile input and add a regression test covering dotted metric and label names.Legacy-compatible input remains accepted. The HTTP handler continues to use
promhttp's existing name-escaping negotiation for scraper compatibility.Testing
go test ./collector -run '^TestTextfileCollector(SupportsUTF8Names)?$' -count=1go test -short ./...GOOS=linux GOARCH=amd64 CGO_ENABLED=0 make lintmake testwith Go 1.26 on LinuxFixes #3700.
cc @SuperQ