clone: rename -p/--path flag to --working-dir#333
Open
colluca wants to merge 3 commits into
Open
Conversation
Align bender clone's flag with bender snapshot's --working-dir, since both refer to the same working-directory concept (and share the same default value). --path was also easy to confuse with the unrelated `bender path` subcommand and path-dependency overrides.
Restores backwards compatibility for scripts using bender clone -p/--path after the previous rename to --working-dir.
-p was still showing in help alongside --working-dir; use short_alias instead of short so it stays functional but hidden, consistent with the hidden --path long alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bender cloneused-p/--pathandbender snapshotused--working-dirfor the same working-directory concept (same default valueworking_dir, same semantics).--working-diris now the primary, documented flag forclonetoo, matchingsnapshot.-p/--pathare kept as fully-working hidden aliases onclonefor backwards compatibility — neither appears in--help, but both still parse.docs/bookreferences and added a CHANGELOG entry.Not a breaking change: existing
-p/--pathusage keeps working.Test plan
cargo check --no-default-featurespassesbender clone --helpshows only--working-dir <WORKING_DIR>(no-p/--path)bender clone -p <dir> <pkg>andbender clone --path <dir> <pkg>still parse correctlybender snapshot --helpshows--working-dir <WORKING_DIR>(unchanged)