Stringify objects when posting a form-encoded body#1401
Merged
Conversation
mdellweg
force-pushed
the
html_form_encode
branch
5 times, most recently
from
99ad0ff to
6fde5c6
Compare
gerrod3
reviewed
May 20, 2026
| if isinstance(body, dict): | ||
| data = {k: encode_stringify(v) for k, v in body.items()} | ||
| else: | ||
| data = encode_param(body) |
Contributor
There was a problem hiding this comment.
What happens if body is a list of dicts? Is this possible?
Member
Author
There was a problem hiding this comment.
Not yet in our api. And I'd need to reread the specification in that case.
| from pulp_glue.common import oas | ||
| from pulp_glue.common.exceptions import SchemaError, ValidationError | ||
| from pulp_glue.common.schema import ( | ||
| encode_html, |
Contributor
There was a problem hiding this comment.
Are you going to add a test for encode_stringify?
mdellweg
force-pushed
the
html_form_encode
branch
from
6fde5c6 to
2bbe681
Compare
mdellweg
force-pushed
the
html_form_encode
branch
from
2bbe681 to
7928b31
Compare
gerrod3
approved these changes
May 27, 2026
Backport to 0.39: 💚 backport PR created✅ Backport PR branch: Backported as #1405 🤖 @patchback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.