Skip to content

[BUGFIX] Inconsistent naming of [cross_]axis_tilt / [cross_]axis_slope#2543

Open
echedey-ls wants to merge 31 commits intopvlib:mainfrom
echedey-ls:cross-axis-whatever-name-consistent-name
Open

[BUGFIX] Inconsistent naming of [cross_]axis_tilt / [cross_]axis_slope#2543
echedey-ls wants to merge 31 commits intopvlib:mainfrom
echedey-ls:cross-axis-whatever-name-consistent-name

Conversation

@echedey-ls
Copy link
Member

@echedey-ls echedey-ls commented Sep 7, 2025

  • Closes cross_axis_slope vs cross_axis_tilt #2334
  • I am familiar with the contributing guidelines
  • Tests added
  • [NA] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [NA] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

pvlib.shading.shaded_fraction1d uses 'cross_axis_slope' as an input, while pvlib.tracking.singleaxis uses 'cross_axis_tilt'. I think these are the same thing - is that correct? If so, would it make sense to update one of them to be consistent?

Extract from the body message, OP @williamhobbs, #2334 .

Also adds variable description to nomenclature page.

Relevant doc pages (old)

Relevant doc pages (new)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api deprecation Use for issues and PRs which involve deprecations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants