-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement ANTS-2D bifacial irradiance model #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kandersolar
wants to merge
48
commits into
pvlib:main
Choose a base branch
from
kandersolar:ants2d
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
d6d6f31
ants2d and new VF code
kandersolar 99a7a81
remove some cruft
kandersolar a6f22bb
add tests for ants2d._shaded_fraction
kandersolar 02686aa
refactoring and more tests
kandersolar 034efd9
tests for _apply_ground_slope
kandersolar 4748915
tests for _apply_sky_diffuse_model
kandersolar d2bf3ad
fix return shape and tests for vf_row_ground_2d_integ
kandersolar 405649b
fix return shape and tests for vf_row_sky_2d_integ
kandersolar 7dd6853
major docstring cleanup
kandersolar 505d8d4
standardize to "back" instead of "rear"
kandersolar 8811daa
shape fixes, pandas out
kandersolar 0907682
bugfix in unshaded ground fraction
kandersolar 8c792ec
add several tests for main function
kandersolar 9d28b75
test updates
kandersolar 2331023
better return type logic; more get_irradiance tests
kandersolar 56fe82b
expose max_rows, more get_irradiance tests
kandersolar 920ec30
fix issue with horizontal array and large max_rows
kandersolar 403c0a4
fix unshaded_ground_fraction for horizontal special case
kandersolar 24c8f32
fix row->ground VF edge case
kandersolar 06f2a97
switch default model from isotropic to perez
kandersolar 69105fd
add hardcoded regression test
kandersolar eaa8fd1
alphabetize module imports
kandersolar 98d1664
docstring work
kandersolar 784877f
utils functions: make height and pitch optional
kandersolar 2cbfb0d
get infinite_sheds working again
kandersolar 7927422
polishing
kandersolar 52d4fc2
fix output when surface angle is scalar but irrad is array
kandersolar 39663ea
simplify numpy import
kandersolar 5a650e4
add option to return irradiance incident on ground surface
kandersolar 28480f7
more tests for ground irradiance
kandersolar 0fa4bc9
one more test
kandersolar 258d5a6
use `assert_allclose`, not `assert np.isclose`
kandersolar 015500d
allow specifying custom row/ground subsets
kandersolar 2b5750a
lint
kandersolar 6e23585
Merge remote-tracking branch 'upstream/main' into ants2d
kandersolar cf1ce33
use `poa_` for `return_components=True` after #2627
kandersolar 92a95b2
misc cleanup
kandersolar e651baf
fix squeeze bug
kandersolar c8be126
deprecate `npoints`, `vectorize`
kandersolar 69eaf67
fix deprecation version
kandersolar 485eb0c
lint
kandersolar e4c0c51
docstring cleanup
kandersolar 30257a7
whatsnew entries
kandersolar a36841d
fix broken gallery example
kandersolar 611f9da
add `reference` docs entry and user guide description
kandersolar e81e250
add test to cover untested branch
kandersolar 5a4d792
feedback from review
kandersolar f329c56
Merge branch 'main' into ants2d
kandersolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.