Skip to content

Declare destroyable attr#232

Merged
MatthiasValvekens merged 1 commit into
pyauth:masterfrom
myksyr-tdy:feature/destroyable_property
Jun 21, 2026
Merged

Declare destroyable attr#232
MatthiasValvekens merged 1 commit into
pyauth:masterfrom
myksyr-tdy:feature/destroyable_property

Conversation

@myksyr-tdy

Copy link
Copy Markdown
Contributor

This is useful when handling persistent objects, like 802.1AR IDevID.

@MatthiasValvekens

Copy link
Copy Markdown
Collaborator

Those failing tests seem to be related to an upstream change (#233). I pushed a change to master to disable the offending test when running against opencryptoki for now.

This is useful when handling persistent objects, like 802.1AR IDevID.
@MatthiasValvekens MatthiasValvekens force-pushed the feature/destroyable_property branch from 4343ffb to 775136e Compare June 21, 2026 19:06
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.45%. Comparing base (1ff2114) to head (775136e).
⚠️ Report is 24 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   90.17%   91.45%   +1.28%     
==========================================
  Files          15       15              
  Lines        2625     2693      +68     
  Branches       29       27       -2     
==========================================
+ Hits         2367     2463      +96     
+ Misses        255      228      -27     
+ Partials        3        2       -1     
Flag Coverage Δ
unittests 91.45% <100.00%> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthiasValvekens MatthiasValvekens merged commit 775136e into pyauth:master Jun 21, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants