test: remove dead PR3068 workaround branch#6109
Open
henryiii wants to merge 1 commit into
Open
Conversation
`WORKAROUND_ENABLING_ROLLBACK_OF_PR3068` compared the 5-element `sys.version_info` tuple to `(3, 9)`, so it was always False. The guarded branch never ran. Remove the constant and keep only the branch that runs. Assisted-by: ClaudeCode:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code can't ever be hit (
sys.version_infowill never be exactly(3, 9)).🤖 AI text below 🤖
Description
tests/test_class_sh_trampoline_shared_from_this.pyhad a constantWORKAROUND_ENABLING_ROLLBACK_OF_PR3068. It comparedsys.version_infoto(3, 9).sys.version_infois a 5-element tuple, so this comparison wasalways False. The guarded branch in
test_std_make_shared_factorynever ransince 2021.
This PR removes the constant and the dead branch. Only the
pytest.raisespath stays, which is the path that always ran. The
import sysline is nowunused, so it is also removed. No other file changes.
Suggested changelog entry: