Deprecate PKey.generate_key, PKey.check, and dump_privatekey#1509
Merged
Conversation
The key generation, loading, and serialization APIs in cryptography should be used instead. https://claude.ai/code/session_01KzTRkDmWNuEfCubRUhVit5
reaperhulk
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
PKey.generate_key,PKey.check, anddump_privatekeyin favor of the key generation, loading, and serialization APIs incryptography.PKeymethods use the@deprecateddecorator (same asget_elliptic_curve(s)), so mypy flags them with--enable-error-code deprecated.dump_privatekeyfollows thedump_certificate_requestprecedent (utils.deprecated+ a_dump_privatekey_internalalias) since it's called internally byPKey.to_cryptography_key, which remains warning-free.The X509Name deprecations are split out and on hold pending the
get_client_ca_listas_cryptographywork (#1508).https://claude.ai/code/session_01KzTRkDmWNuEfCubRUhVit5
Generated by Claude Code