Reject scalar coordinates as plot axes#11450
Draft
sdraeger wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Codex <noreply@anthropic.com>
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #7333.
Facet coordinates remain attached as zero-dimensional coordinates after
FacetGridselects each panel._infer_xy_labelsaccepted those coordinates as plotting axes, causing the 2D plotting code to index a nonexistent first dimension and raiseIndexError.This change rejects zero-dimensional x/y coordinates during label inference and raises a clear
ValueErrorinstead. It also adds a regression test covering a faceting coordinate passed as an axis.Tests
uv run pytest xarray/tests/test_plot.pypre-commit run --files xarray/plot/utils.py xarray/tests/test_plot.pyChecklist
whats-new.rstAI Disclosure
Tools: Codex