Skip to content

chore(structure): split hook modules into role-specific files - #703

Draft
RonnyPfannschmidt wants to merge 2 commits into
pytest-dev:mainfrom
RonnyPfannschmidt:refactor/split-hook-modules
Draft

chore(structure): split hook modules into role-specific files#703
RonnyPfannschmidt wants to merge 2 commits into
pytest-dev:mainfrom
RonnyPfannschmidt:refactor/split-hook-modules

Conversation

@RonnyPfannschmidt

@RonnyPfannschmidt RonnyPfannschmidt commented Jul 22, 2026

Copy link
Copy Markdown
Member

Merge PR — step 1 of 7.

This PR targets main and is the bottom of the stack, so it is ready to merge on its own. Review discussion happens in RonnyPfannschmidt#6.

Step Branch Review (downstream) Merge (upstream)
1 refactor/split-hook-modules RonnyPfannschmidt#6 #703
2 refactor/configuration-objects RonnyPfannschmidt#5 #704
3 refactor/markers-attach-config RonnyPfannschmidt#7 #706
4 refactor/hookimpl-wrapper-types RonnyPfannschmidt#8 #707
5 refactor/hookcaller-and-execution RonnyPfannschmidt#9 #708
6 refactor/project-spec RonnyPfannschmidt#10 #709
7 refactor/async-submitter RonnyPfannschmidt#11 #710

Summary

  • Split monolithic _hooks.py / _callers.py into role modules: _config, _decorators, _caller, _implementation, _execution
  • Keep _hooks and _callers as re-export shims so existing imports keep working
  • Behavior-preserving foundation for later typed config / CompletionHook / Protocol caller work

Test plan

  • uv run pytest (139 passed)
  • uv run pre-commit run -a
  • CI green on this PR

Made with Cursor

@RonnyPfannschmidt
RonnyPfannschmidt force-pushed the refactor/split-hook-modules branch from 8c3f2f7 to 7489fdb Compare July 24, 2026 16:53
@RonnyPfannschmidt
RonnyPfannschmidt force-pushed the refactor/split-hook-modules branch 2 times, most recently from 87bccf2 to f795cf2 Compare August 12, 2026 10:57
RonnyPfannschmidt and others added 2 commits August 12, 2026 13:13
Add the design/ writeup chain (decisions + per-step docs 01-07) that
guides the stacked refactoring branches. Exclude design/ from
blacken-docs since the docs use elided pseudo-code signatures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Move hook types, markers, callers, implementations, and multicall out of
the monolithic _hooks/_callers modules so later typed-config and
CompletionHook work can land without thrashing one huge file. Keep
_hooks and _callers as re-export shims for import compatibility.

Co-authored-by: Cursor AI <ai@cursor.sh>
Co-authored-by: Cursor Grok 4.5 <grok@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant