Skip to content

Doc: commit access follows demonstrated judgement, not a single clean PR #14790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RonnyPfannschmidt wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −6
Open

Doc: commit access follows demonstrated judgement, not a single clean PR #14790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,12 +468,28 @@ If in doubt, go ahead and open a PR with your best guess and we can discuss this
Joining the Development Team
----------------------------

Anyone who has successfully seen through a pull request which did not
require any extra work from the development team to merge will
themselves gain commit access if they so wish (if we forget to ask please send a friendly
reminder). This does not mean there is any change in your contribution workflow:
everyone goes through the same pull-request-and-review process and
no-one merges their own pull requests unless already approved. It does however mean you can
Commit access is an invitation the development team extends once a contributor
has shown a developed sense for the project -- its scope, its conventions, and
what a change costs the people who depend on it.

This section used to promise commit access to anyone who saw a pull request
through without the team having to do extra work. That bar was a good proxy
for the real thing back then: getting something non-trivial merged in one go
meant you had already built that sense. It no longer works as a proxy, both
because pytest carries far more responsibility today and because a pull
request that looks clean is now much cheaper to produce than the judgement
behind it.
Comment on lines +475 to +481

@Pierre-Sassoulas Pierre-Sassoulas Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have to explain the past and the reason for the change here, maybe the PR description is the proper place. (but this can ship anyway)


So there is no threshold you can clear on demand. What we look for is that
judgement shown over time -- in the changes you propose, in the reviews and
discussions you take part in, and in a feel for which changes are not worth
making. We reach out when we think the time has come, so please don't feel
you have to ask, and please don't read not having been asked yet as a verdict
on your contributions.

Commit access does not change your contribution workflow: everyone goes
through the same pull-request-and-review process and no-one merges their own
pull requests unless already approved. It does however mean you can
Comment on lines +490 to +492

@Pierre-Sassoulas Pierre-Sassoulas Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

participate in the development process more fully since you can merge
pull requests from other contributors yourself after having reviewed
them.
Expand Down