Accept integer TOML truncation limits - #14796
Closed
DresdenGman wants to merge 1 commit into
Closed
Conversation
Member
|
Dupe of #14692, the first thing an AI should do before doing those automated fixes deemed easy should be to check if something already exists. This is the 6th time an AI MR is opened for this; it's infuriating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14675.
Register
truncation_limit_linesandtruncation_limit_charsasint | str. This accepts native TOML integers while preserving existing string-based configuration formats and-ooverrides.The truncation consumer already converts both values with
int(). The regression test now runs the existing threshold cases against both INI and native TOML configuration.Tests:
PYTHONPATH=src python -m pytest -q testing/test_assertion.py::TestTruncateExplanation::test_truncation_with_config