fix: propagate pytestmark from __init__.py to Package collector - #14798
Closed
waterWang wants to merge 1 commit into
Closed
fix: propagate pytestmark from __init__.py to Package collector#14798waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14737
Problem
When a
pytestmarkis defined in a package's__init__.py, it is no longer propagated to tests within that package. This worked in earlier versions but was broken by a refactoring.Root Cause
Package.setup()imports the__init__.pymodule viaimporttestmodule()but never reads thepytestmarkattribute from it. Theget_unpacked_marks()function (already imported) is used elsewhere (e.g., inPyobjMixin._filter_with_own_markers) to extract marks from module objects, but was never called for the__init__.pymodule inPackage.setup().Fix
Added
get_unpacked_marks(init_mod)call inPackage.setup()after importing the__init__.pymodule. The extracted marks are added toself.own_markersandself.keywords, which is consistent with how other collectors handle marks (seePyobjMixinat line 313 andFunctionDefinition.__init__at line 1709).Testing
pytestmark = pytest.mark.skip(reason="package skip")in__init__.pynow correctly skips tests in the packageiter_markers()on package-level markers now includes marks from__init__.py