Document tobytes() copy behavior in NumPy array hashing#343
Merged
shaypal5 merged 2 commits intoFeb 18, 2026
Merged
Conversation
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update NumPy-aware hashing based on feedback
Document tobytes() copy behavior in NumPy array hashing
Feb 18, 2026
shaypal5
merged commit c33c6be
into
codex/add-test-and-benchmark-for-numpy-array-performance
1 check passed
shaypal5
added a commit
that referenced
this pull request
Mar 20, 2026
* Initial plan * Document tobytes(order="C") behavior in _hash_numpy_array docstring Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
shaypal5
added
AI & Agents
area: agent-workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_hash_numpy_arrayfunction usestobytes(order="C")to ensure consistent hashing regardless of memory layout, but this can incur a copy for non-contiguous arrays.Changes
_hash_numpy_array: Documents thattobytes(order="C")may copy data for non-contiguous arrays (transposed, sliced views, Fortran-ordered) with performance implications for large arrays. Includes best practices in Notes section.The behavior is correct and intentional—C-order normalization ensures deterministic hashes—but now explicitly documented for users working with large non-contiguous arrays.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.