Add benchmark tests#9654
Open
akx wants to merge 4 commits into
Open
Conversation
e3d4585 to
6eb80ce
Compare
radarhere
reviewed
Jun 4, 2026
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #9649 and python-pillow/pillow-perf#161.
This PR ports most Pillow-related tests from pillow-perf, modernized (no more compatibility with ancient versions of Pillow), converted to pytest-benchmark style, and also jams in the blend benchmark I used to measure #9649's impact.
The file lives under
Tests/, as it is a pytest file (and some benchmarks use test fixture images), but is not namedtest_*, so it will not be automatically collected as a test (and nothing untoward should happen if you don't havepytest-benchmarkinstalled).The second commit in this PR wires benchmarks into CI after successful tests.
On my Macbook, running the whole benchmark suite takes about 200 seconds right now -- in CI, this could be adjusted with e.g.
--benchmark-max-timeat the possible expense of measurement fidelity. Also, some of the benchmarks are currently somewhat exhaustive (combinatorialparametrizes). EDIT: Ugh, about 5 minutes (so longer than the test suite) in CI 😅