Add ASYNC128 task-status-never-started - #474
Open
Zac-HD wants to merge 1 commit into
Open
Conversation
Warns about startable functions (i.e. taking a `task_status` parameter, or a parameter annotated as `TaskStatus`) that never call `task_status.started()`, which makes `nursery.start()` / `TaskGroup.start()` calls on them fail or block forever. The check is intentionally strict, per the issue: passing `task_status` on to a helper function or aliasing it does not count, and any direct call counts regardless of reachability. Stub bodies (overloads, protocols, abstract methods) are excluded. Closes python-trio#471 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EJGxyMtQSge3dVQpw19rZX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warns about startable functions (i.e. taking a
task_statusparameter, or a parameter annotated asTaskStatus) that never calltask_status.started(), which makesnursery.start()/TaskGroup.start()calls on them fail or block forever.The check is intentionally strict, per the issue: passing
task_statuson to a helper function or aliasing it does not count, and any direct call counts regardless of reachability. Stub bodies (overloads, protocols, abstract methods) are excluded.Closes #471.