Drop extras from _resolved_key to prevent re-entrant bootstrap failure#985
Closed
LalatenduMohanty wants to merge 2 commits intopython-wheel-build:mainfrom
Closed
Conversation
ryanpetrello
approved these changes
Mar 25, 2026
LalatenduMohanty
force-pushed
the
fix/issue-984-resolved-key-extras
branch
from
8a006b5 to
ce98211
Compare
…nt bootstrap failure Extras were included in the seen-check key, so the same package with different extras (e.g. setuptools-scm vs setuptools-scm[toml]) bypassed cycle detection and tried to install dependencies whose wheels hadn't been built yet. Closes: python-wheel-build#984 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
added a commit
to LalatenduMohanty/fromager
that referenced
this pull request
Mar 25, 2026
The constraint was a workaround for python-wheel-build#982, which was caused by extras in _resolved_key triggering re-entrant bootstrap failures. The root cause is now fixed by PR 985 [1], making this pin unnecessary. [1] python-wheel-build#985 Reverts: python-wheel-build#983 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
fix/issue-984-resolved-key-extras
branch
from
ce98211 to
f388ade
Compare
The constraint was a workaround for the issue (commit 141d857), which was caused by extras in _resolved_key triggering re-entrant bootstrap failures. The root cause is now fixed by PR 985 [1], making this pin unnecessary. [1] python-wheel-build#985 Reverts: python-wheel-build#983 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
fix/issue-984-resolved-key-extras
branch
from
f388ade to
344fc01
Compare
Member
Author
|
The CI is failing because of a circular build dependency issue: hatchling → (transitive) → setuptools-scm 10.0.2 → vcs-versioning → hatchling. The bootstrapper's depth-first walk detects the Upstream circular dependency issue pypa/setuptools-scm#1302 |
dhellmann
requested changes
Mar 26, 2026
Member
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
This change is not correct.
| """Return a key for tracking whether a package has already been resolved. | ||
|
|
||
| Extras are intentionally excluded because a build is the same | ||
| regardless of extras. |
Member
There was a problem hiding this comment.
It's not the same at all. That's the point of extras. If we don't include extras here then building torch appears to be the same as building torch[cuda] except it does not include the cuda dependencies.
Member
Author
There was a problem hiding this comment.
Good point. Going to close this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extras were included in the seen-check key, so the same package with different extras (e.g. setuptools-scm vs setuptools-scm[toml]) bypassed cycle detection and tried to install dependencies whose wheels hadn't been built yet.
Also reverting the setuptools-scm<10 constraint as we do not need this constraint anymore.
Closes: #984