gh-146121: pkgutil.get_data() reject invalid resource arguments#146122
Merged
FFY00 merged 4 commits intopython:mainfrom Mar 18, 2026
Merged
gh-146121: pkgutil.get_data() reject invalid resource arguments#146122FFY00 merged 4 commits intopython:mainfrom
pkgutil.get_data() reject invalid resource arguments#146122FFY00 merged 4 commits intopython:mainfrom
Conversation
StanFromIreland
requested review from
FFY00 and
ericsnowcurrently
as code owners
StanFromIreland
added
needs backport to 3.10
FFY00
reviewed
Mar 18, 2026
Lib/test/test_pkgutil.py
Outdated
Comment on lines
+78
to
+79
| with self.assertRaises(ValueError): | ||
| pkgutil.get_data(pkg, '/etc/passwd') |
Member
There was a problem hiding this comment.
Right, this should be POSIX-only. We should also add a test for absolute Windows paths.
Member
Author
There was a problem hiding this comment.
Oh, that doesn’t work either (I'm unfamiliar with Windows... :-( )
Member
Author
There was a problem hiding this comment.
Suggested change
| with self.assertRaises(ValueError): | |
| pkgutil.get_data(pkg, '/etc/passwd') | |
| with self.assertRaises(ValueError): | |
| pkgutil.get_data(pkg, os.path.abspath('/etc/passwd')) |
Maybe this will work
|
Thanks @StanFromIreland for the PR, and @FFY00 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
…ts (pythonGH-146122) (cherry picked from commit bcdf231946b1da8bdfbab4c05539bb0cc964a1c7) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
…ts (pythonGH-146122) (cherry picked from commit bcdf231) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-146133 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
…ts (pythonGH-146122) (cherry picked from commit bcdf231) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-146134 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
…ts (pythonGH-146122) (cherry picked from commit bcdf231) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2026
…ts (pythonGH-146122) (cherry picked from commit bcdf231) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-146135 is a backport of this pull request to the 3.12 branch. |
|
GH-146136 is a backport of this pull request to the 3.11 branch. |
|
GH-146137 is a backport of this pull request to the 3.10 branch. |
Member
Author
|
Thanks for the review Filipe! 73 :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkgutil.get_data()restrictions are not enforced #146121