gh-145866 : Update JIT contributor list (GH-146170)#146177
Closed
okiemute04 wants to merge 1 commit intopython:mainfrom
Closed
gh-145866 : Update JIT contributor list (GH-146170)#146177okiemute04 wants to merge 1 commit intopython:mainfrom
okiemute04 wants to merge 1 commit intopython:mainfrom
Conversation
okiemute04
force-pushed
the
fix-pyexpat-reentrant-crash
branch
5 times, most recently
from
6dfc9f5 to
a11970d
Compare
Member
What is this PR, it copies part of #146170? |
okiemute04
force-pushed
the
fix-pyexpat-reentrant-crash
branch
from
a11970d to
44b6ed9
Compare
okiemute04
force-pushed
the
fix-pyexpat-reentrant-crash
branch
from
44b6ed9 to
9caa414
Compare
|
Not quite sure what's going on with the title/links here, but this seems related to #146169 |
Contributor
Author
|
@StanFromIreland @stestagg This PR got contaminated with unrelated commits. The actual fix for #146174 is now in a clean PR at #146179. Closing this one to avoid confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146174
Add a check in
Parse()to prevent calls whenin_callbackis true,as this violates expat's requirements and can cause crashes. Now raises
RuntimeErrorwith a clear message._POP_TOP#145866📚 Documentation preview 📚: https://cpython-previews--146177.org.readthedocs.build/