Skip to content

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs#146417

Merged
vstinner merged 8 commits intopython:mainfrom
hoodmane:streams
Mar 30, 2026
Merged

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs#146417
vstinner merged 8 commits intopython:mainfrom
hoodmane:streams

Conversation

@hoodmane
Copy link
Copy Markdown
Contributor

@hoodmane hoodmane commented Mar 25, 2026 •
edited by bedevere-app bot
Loading

@hoodmane hoodmane requested review from freakboy3742 and removed request for AA-Turner, corona10, emmatyping and erlend-aasland March 25, 2026 13:13
@bedevere-app bedevere-app bot mentioned this pull request Mar 25, 2026
Closed
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Mar 25, 2026

The test suite fails on Emscripten with nodeFsync is not defined: https://github.com/python/cpython/actions/runs/23545540285/job/68544804717?pr=146417


0:00:13 load avg: 0.10 [ 78/502] test.test_os.test_os
file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:189
    nodeFsync(this.nodeStream.fd);
    ^

ReferenceError: nodeFsync is not defined
    at NodeWriter.fsync (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:189:5)
    at Object.fsync (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:136:11)
    at Object.close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:131:23)
    at Object.close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/python.mjs:1:71931)
    at _fd_close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/python.mjs:1:271594)
    at wasm://wasm/02b6ddae:wasm-function[12183]:0x69a8ab
    at wasm://wasm/02b6ddae:wasm-function[8357]:0x498ddf
    at wasm://wasm/02b6ddae:wasm-function[1978]:0x1e167a
    at wasm://wasm/02b6ddae:wasm-function[803]:0x18e943
    at wasm://wasm/02b6ddae:wasm-function[3473]:0x2ad92d

Node.js v24.14.0
Error: Process completed with exit code 1.

vstinner
vstinner reviewed Mar 30, 2026
View reviewed changes
hoodmane and others added 2 commits March 30, 2026 12:05
@hoodmane @vstinner
Apply suggestions from code review
245cb86 
Co-authored-by: Victor Stinner <vstinner@python.org>
@hoodmane
Sleep only 10ms
36a307e
@hoodmane
Copy link
Copy Markdown
Contributor Author

hoodmane commented Mar 30, 2026

Thanks for the review @vstinner!

vstinner
vstinner approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 6857de6 into python:main Mar 30, 2026
50 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Mar 30, 2026

Thanks @hoodmane for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2026
@hoodmane @vstinner @miss-islington
pythongh-146416: Emscripten: Improve standard stream handling in node…
2d93923 
…_entry.mjs (pythonGH-146417)

(cherry picked from commit 6857de625f1ab256c0ce48d9c8280d678d61bab1)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 30, 2026

GH-146630 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 30, 2026
@hoodmane hoodmane deleted the streams branch March 30, 2026 11:28
vstinner added a commit that referenced this pull request Mar 30, 2026
@miss-islington @hoodmane @vstinner
[3.14] gh-146416: Emscripten: Improve standard stream handling in nod…
ec11485 
…e_entry.mjs (GH-146417) (#146630)

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (GH-146417)
(cherry picked from commit 6857de6)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 30, 2026
@maurycy
Merge remote-tracking branch 'upstream/main' into tachyon-ndjson-kole…
6a0ea81 
…ktor

* upstream/main: (119 commits)
  pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845)
  pythongh-146558: JIT optimize dict access for objects with known hash (python#146559)
  pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570)
  pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)
  pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593)
  pythongh-138122: Add differential flame graph (python#145785)
  pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417)
  pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628)
  pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
  pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624)
  pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597)
  pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557)
  pythongh-146579: _zstd: Fix decompression options dict error message (python#146577)
  pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085)
  pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573)
  pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569)
  pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472)
  pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580)
  pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004)
  pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoodmane @vstinner