gh-146381: Fold frozendict(key=const, ...) calls to LOAD_CONST#146423
Draft
corona10 wants to merge 1 commit intopython:mainfrom
Draft
gh-146381: Fold frozendict(key=const, ...) calls to LOAD_CONST#146423corona10 wants to merge 1 commit intopython:mainfrom
corona10 wants to merge 1 commit intopython:mainfrom
Conversation
Member
Author
|
Member
Author
|
Since @Fidget-Spinner suggeted to optimize from JIT pipeline directly, I covert this PR to the draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR folds
frozendictcalls intoLOAD_CONSTat compile time.This is a prerequisite for JIT constant folding of frozendict lookups. Without this,
frozendictcompiles to CALL_KW, which the JIT cannot recognize as a constant. With this change, it becomes LOAD_CONST frozendict(...), enabling the JIT to promote it and fold subscript operations like d['x'] at optimization time.Without codegen-level folding like this, supporting frozendict constants in the JIT would likely require introducing a new literal syntax (e.g., <1: 3, 5: 6>) at the language level, and it might need a PEP for this change.
cc @vstinner