Skip to content

gh-149521: Do not update last_profiled_frame if it's not changed #149522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 3 commits into from
May 8, 2026
+8 −6
Merged

gh-149521: Do not update last_profiled_frame if it's not changed #149522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a07c4a
one less syskall
maurycy May 7, 2026
75685a6
Merge branch 'main' into remote-debugging-last-profiled-frame
maurycy May 8, 2026
570fdfc
Merge branch 'main' into remote-debugging-last-profiled-frame
maurycy May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Modules/_remote_debugging/threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,12 +450,14 @@ unwind_stack_for_thread(
set_exception_cause(unwinder, PyExc_RuntimeError, "Failed to collect frames");
goto error;
}
// Update last_profiled_frame for next sample
uintptr_t lpf_addr =
*current_tstate + (uintptr_t)unwinder->debug_offsets.thread_state.last_profiled_frame;
if (_Py_RemoteDebug_WriteRemoteMemory(&unwinder->handle, lpf_addr,
sizeof(uintptr_t), &frame_addr) < 0) {
PyErr_Clear(); // Non-fatal
// Update last_profiled_frame for next sample if it changed
if (frame_addr != ctx.last_profiled_frame) {
uintptr_t lpf_addr =
*current_tstate + (uintptr_t)unwinder->debug_offsets.thread_state.last_profiled_frame;
if (_Py_RemoteDebug_WriteRemoteMemory(&unwinder->handle, lpf_addr,
sizeof(uintptr_t), &frame_addr) < 0) {
PyErr_Clear(); // Non-fatal
}
}
} else {
// No caching - process entire frame chain with base_frame validation
Expand Down
Loading