Skip to content

gh-151560: fix AttributeError when running test.test_importlib.resources.test_resource#151561

Merged
FFY00 merged 5 commits into
python:mainfrom
ringobanana-3900:test_importlib
Jun 22, 2026
Merged

gh-151560: fix AttributeError when running test.test_importlib.resources.test_resource#151561
FFY00 merged 5 commits into
python:mainfrom
ringobanana-3900:test_importlib

Conversation

@ringobanana-3900

@ringobanana-3900 ringobanana-3900 commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

@ringobanana-3900
[pythongh-151560]
8c049c7 
import MetaPathFinder, Loader from importlib.abc
+ make it used
@python-cla-bot

python-cla-bot Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Jun 16, 2026
Closed
@bedevere-app

bedevere-app Bot commented Jun 16, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Jun 16, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Jun 20, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz

picnixz commented Jun 20, 2026

Copy link
Copy Markdown
Member

Please don't update your branch without good reasons. See https://devguide.python.org/getting-started/pull-request-lifecycle/#update-branch-button.

@picnixz picnixz changed the title gh-151560: import MetaPathFinder, Loader and make it used gh-151560: fix AttributeError when running test.test_importlib.resources.test_resource Jun 20, 2026
@ringobanana-3900

ringobanana-3900 commented Jun 20, 2026

Copy link
Copy Markdown
Author

Oh, I'm sorry for the trouble.
Thank you for applying the skip news label!

picnixz
picnixz reviewed Jun 20, 2026
View reviewed changes
Comment thread Lib/test/test_importlib/resources/util.py Outdated
@FFY00 FFY00 enabled auto-merge (squash) June 22, 2026 13:48
@FFY00 FFY00 merged commit b8786dc into python:main Jun 22, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

@FFY00 FFY00 FFY00 approved these changes

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ringobanana-3900 @picnixz @FFY00