Skip to content

gh-153438: Update NuGet download URL - #153482

Merged
zooba merged 1 commit into
python:mainfrom
harjothkhara:codex/gh-153438-nuget-url
Jul 10, 2026
Merged

gh-153438: Update NuGet download URL#153482
zooba merged 1 commit into
python:mainfrom
harjothkhara:codex/gh-153438-nuget-url

Conversation

@harjothkhara

@harjothkhara harjothkhara commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Closes #153438.

The aka.ms/nugetclidl redirect no longer resolves to nuget.exe, which
breaks Windows build bootstrapping when no suitable Python is installed.

This change:

  • uses the current NuGet CLI download URL in both the regular Windows build
    bootstrap and MSI external-dependency bootstrap;
  • updates the matching Windows documentation; and
  • adds a Build NEWS entry.

Validation:

  • Tools/patchcheck/patchcheck.py against the staged diff
  • git diff --cached --check
  • replacement endpoint returns HTTP 200 with
    Content-Type: application/x-msdownload

The Windows batch execution itself was not run locally because the development
host is macOS.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33525863 | 📁 Comparing 6c44585 against main (6c389c4)

  🔍 Preview build  

2 files changed
± using/windows.html
± whatsnew/changelog.html

@harjothkhara
harjothkhara marked this pull request as ready for review July 10, 2026 05:55
@harjothkhara
harjothkhara requested a review from a team as a code owner July 10, 2026 05:55
@zooba zooba added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 10, 2026
@zooba
zooba merged commit 106eb53 into python:main Jul 10, 2026
61 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @harjothkhara for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

GH-153509 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 10, 2026
@miss-islington-app

Copy link
Copy Markdown

Sorry, @harjothkhara and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 106eb532ea3b243423e62a702719e9d3c0e40c16 3.13

@bedevere-app

bedevere-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

GH-153510 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 10, 2026
zooba pushed a commit that referenced this pull request Jul 10, 2026
gh-153438: Update NuGet download URL (GH-153482)
(cherry picked from commit 106eb53)

Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
zooba pushed a commit that referenced this pull request Jul 10, 2026
gh-153438: Update NuGet download URL (GH-153482)
(cherry picked from commit 106eb53)

Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
@bedevere-app

bedevere-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

GH-153515 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 10, 2026
zooba added a commit that referenced this pull request Jul 10, 2026
gh-153438: Update NuGet download URL (GH-153482)
(cherry picked from commit 106eb53)

Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Jul 11, 2026
Yhg1s pushed a commit that referenced this pull request Aug 4, 2026
…153608)

[3.13] gh-153438: Update NuGet download URL (GH-153482) (GH-153515)

gh-153438: Update NuGet download URL (GH-153482)
(cherry picked from commit 106eb53)
(cherry picked from commit 62eb50d)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
hugovk pushed a commit that referenced this pull request Aug 10, 2026
…153609)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
hugovk pushed a commit that referenced this pull request Aug 10, 2026
…153610)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.11 (tier-3) has failed when building commit 32eb314.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1230/builds/547) and take a look at the build logs.
  4. Check if the failure is related to this commit (32eb314) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1230/builds/547

Failed tests:

  • test_httpservers

Failed subtests:

  • test_large_content_length_truncated - test.test_httpservers.CGIHTTPServerTestCase.test_large_content_length_truncated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/test/test_httpservers.py", line 906, in test_large_content_length_truncated
    res = self.request('/cgi-bin/file1.py', 'POST', b'x', headers)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/test/test_httpservers.py", line 86, in request
    return self.connection.getresponse()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/http/client.py", line 1443, in getresponse
    response.begin()
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/http/client.py", line 337, in begin
    version, status, reason = self._read_status()
                              ^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/http/client.py", line 306, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/test/test_httpservers.py", line 906, in test_large_content_length_truncated
    res = self.request('/cgi-bin/file1.py', 'POST', b'x', headers)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/test/test_httpservers.py", line 86, in request
    return self.connection.getresponse()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/http/client.py", line 1443, in getresponse
    response.begin()
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/http/client.py", line 337, in begin
    version, status, reason = self._read_status()
                              ^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/http/client.py", line 298, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.11.opsec-fbsd14/build/Lib/socket.py", line 718, in readinto
    return self._sock.recv_into(b)
           ^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 54] Connection reset by peer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PCbuild/find_python.bat uses broken aka.ms/nugetclidl URL for downloading nuget.exe

3 participants