gh-155493: Fix crash in decimal SignalDict on re-entrant Context teardown - #155494
Open
tonghuaroot wants to merge 1 commit into
Open
gh-155493: Fix crash in decimal SignalDict on re-entrant Context teardown#155494tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…t teardown signaldict_setitem and signaldict_richcompare read the borrowed flags pointer after PyObject_IsTrue calls the value's __bool__, which can deallocate the owning Context. pythongh-146011 added this guard to signaldict_repr; this extends it to the two remaining methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signaldict_setitemandsignaldict_richcompareread the borrowed flagspointer after
PyObject_IsTruecalls the value's__bool__, which candeallocate the owning
Context. gh-146011 added this guard tosignaldict_repr; this extends it to the two remaining methods that borrowthe pointer across a Python call.