Skip to content

gh-155621: Fix unrepresentable defaults in socket.sendmsg() signature #155623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
Aug 14, 2026
+6 −7
Merged

gh-155621: Fix unrepresentable defaults in socket.sendmsg() signature #155623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d23f31
Fix unrepresentable defaults in socket.sendmsg() signature
lpyu001 Aug 12, 2026
3da62af
address review
lpyu001 Aug 14, 2026
61d5b24
fix test failed
lpyu001 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_inspect/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6340,7 +6340,7 @@ def test_socket_module_has_signatures(self):
# depends on the number of the arguments.
methods_no_signature = {'ioctl', 'sendto', 'setsockopt'}
# These have parameters with unrepresentable default values.
methods_unsupported_signature = {'listen', 'sendmsg', 'sendmsg_afalg'}
methods_unsupported_signature = {'listen', 'sendmsg_afalg'}
defined = vars(socket.SocketType).keys()
self._test_module_has_signatures(socket,
no_signature, unsupported_signature,
Expand Down
5 changes: 2 additions & 3 deletions Modules/clinic/socketmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Modules/socketmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4990,9 +4990,9 @@ sock_sendmsg_impl(PySocketSockObject *s, void *data)
_socket.socket.sendmsg
self as s: self(type="PySocketSockObject *")
buffers as data_arg: object
ancdata as cmsg_arg: object = NULL
ancdata as cmsg_arg: object(c_default="NULL") = ()
flags: int = 0
address as addr_arg: object = NULL
address as addr_arg: object(c_default="NULL") = None
/

Send normal and ancillary data to the socket.
Expand All @@ -5016,7 +5016,7 @@ static PyObject *
_socket_socket_sendmsg_impl(PySocketSockObject *s, PyObject *data_arg,
PyObject *cmsg_arg, int flags,
PyObject *addr_arg)
/*[clinic end generated code: output=3b4cb1110644ce39 input=8ae408971a3aa329]*/
/*[clinic end generated code: output=3b4cb1110644ce39 input=5fdf9b49bed3848b]*/

{
Py_ssize_t i, ndatabufs = 0, ncmsgs, ncmsgbufs = 0;
Expand Down
Loading