Add ast-serialize as an optional dependency#21028
Open
ilevkivskyi wants to merge 4 commits intopython:masterfrom
Open
Add ast-serialize as an optional dependency#21028ilevkivskyi wants to merge 4 commits intopython:masterfrom
ilevkivskyi wants to merge 4 commits intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Mar 17, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Nice, this makes it easier to use the new parser. Now we need to be a bit more careful with with the design of the public API and the binary format before the next public release, so that we can avoid backward incompatible changes in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A skipped test in
check-overloads.testseems to be caused by a recent change inast_serialize. FWIW it looks like a bug in the old parser? Leaving the test up to @JukkaL