Improve native parser version mismatch errors#21438
Open
cyphercodes wants to merge 1 commit intopython:masterfrom
Open
Improve native parser version mismatch errors#21438cyphercodes wants to merge 1 commit intopython:masterfrom
cyphercodes wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21412.
When parallel checking is used with an incompatible
ast-serializeversion, mypy now reports a clear blocking error instead of surfacing an internal error from the native parser worker path.Test Plan
pytest -n0 -q mypy/test/test_nativeparse.py::TestNativeParserBinaryFormatpytest -n0 -q mypy/test/test_nativeparse.pypython -m mypy --config-file mypy_self_check.ini mypy/parse.py mypy/nativeparse.py mypy/test/test_nativeparse.pypre-commit run --files mypy/nativeparse.py mypy/parse.py mypy/test/test_nativeparse.pygit diff --checkAlso smoke-tested
ast-serialize==0.2.0withpython -m mypy -n2 --no-incremental ...and confirmed it now reports an incompatible-version error instead of anINTERNAL ERROR, then restoredast-serialize==0.3.0and reran the parallel smoke successfully.