Fix auto-upgrade to windowed mode with legacy installer.#286
Merged
zooba merged 3 commits intopython:mainfrom Mar 20, 2026
Merged
Fix auto-upgrade to windowed mode with legacy installer.#286zooba merged 3 commits intopython:mainfrom
zooba merged 3 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
Jesse205
force-pushed
the
fix/legacy-upgrade-windowed
branch
from
b57b729 to
747e01b
Compare
Jesse205
force-pushed
the
fix/legacy-upgrade-windowed
branch
from
747e01b to
6321223
Compare
Member
|
Looks great, thanks! I assume the CI tests will agree, so once they're clean, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, I submitted an enhancement in #216 and supported it in #254. However, after updating pymanager to the latest version, a command line window still pops up. After my analysis, when using the traditional installer but not installing any Python through pymanager, the logic
if is_wdefault or windowed:is not executed; instead, the code enters theif sh_cmd.match("python*.exe"):block. But this block does not support the aforementioned enhancement. This PR fixes this issue.I've modified the existing tests for this fix. If there are any errors in my changes, please let me know.