Generic form system: GraphQL query side (PR 2/5) - #4707
Open
marcoacierno wants to merge 4 commits into
Open
Conversation
conference.form(purpose) returns the form configured for the given purpose (null when unconfigured) with its active questions in order: label, description, type, required, maxLength and select options. Query-side only; submitting answers lands with the grants integration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Summary: Adds a read-only No significant issues found. One thing worth confirming with the author:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## generic-forms/01-app #4707 +/- ##
========================================================
+ Coverage 92.45% 92.47% +0.02%
========================================================
Files 358 359 +1
Lines 10888 10921 +33
Branches 852 852
========================================================
+ Hits 10066 10099 +33
Misses 706 706
Partials 116 116 🚀 New features to boost your workflow:
|
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second PR of the generic form system stack (stacked on #4705 — review that first). Read-only GraphQL surface for conference forms:
conference.form(purpose: FormPurpose)→Form | null, mirroring the existingdeadline(type)patternForm { id, name, questions }with questions active-only, ordered byorderFormQuestion { id, label, description, questionType, required, maxLength, options { id, label } }FormPurpose/FormQuestionType(explicit names to keep the schema namespace clean)Additive schema change only — no mutations, no existing types touched beyond the new
Conference.formfield.Test plan
api/generic_forms/tests/): null when unconfigured / wrong purpose / other conference; full field shape; options exposure; ordering; inactive questions hiddenStack: PR1 #4705 → PR2 (this) → PR3 grants backend → PR4 admin display/export → PR5 frontend.