Skip to content

Update Docker Readme to include instructions for Low Disk Storage problem#345

Open
ShatilKhan wants to merge 2 commits into
pytorch-ignite:mainfrom
ShatilKhan:doc
Open

Update Docker Readme to include instructions for Low Disk Storage problem#345
ShatilKhan wants to merge 2 commits into
pytorch-ignite:mainfrom
ShatilKhan:doc

Conversation

@ShatilKhan

Copy link
Copy Markdown

Description

I've added a link to this hackmd post in the docker readme on how to setup the environment in case of low storage on C Drive

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other (Documentation Update)

cc: @vfdev-5

@netlify

netlify Bot commented Dec 25, 2023

Copy link
Copy Markdown

👷 Deploy request for code-generator pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e296cae

Comment thread docker/readme.md Outdated
@vfdev-5

vfdev-5 commented Dec 25, 2023

Copy link
Copy Markdown
Member

@ShatilKhan I think it would be better to incorporate the text from hackmd into this README directly.

@ShatilKhan

Copy link
Copy Markdown
Author

I was actually thinking the same thing
Then I'll add the hackmd text on my next commit

@vfdev-5

vfdev-5 commented Jan 15, 2024

Copy link
Copy Markdown
Member

@ShatilKhan any updates on this PR?

@ShatilKhan

Copy link
Copy Markdown
Author

@ShatilKhan any updates on this PR?

Yes I'm working on it, I'll update it soon

@ShatilKhan ShatilKhan left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated readme to include full instructions

@vfdev-5

vfdev-5 commented Jan 23, 2024

Copy link
Copy Markdown
Member

@ShatilKhan thanks for the update, but the content starting from horizontal line and the text "After setting up Docker and whatever the issue with space and docker is:" does not look neat and more like a dump various notes.
Can you restructure such that it keeps existing logic of headers levels and the content logic, also fix the indents in the vscode config?

Here is how it looks like now: https://github.com/pytorch-ignite/code-generator/blob/e296caeb8f6150870f17984de0f4b0cce5194118/docker/readme.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants