Skip to content

remove deprecated guard_size_oblivious from stride sorting logic in exir.#19516

Open
laithsakka wants to merge 1 commit into
pytorch:mainfrom
laithsakka:export-D104701778
Open

remove deprecated guard_size_oblivious from stride sorting logic in exir.#19516
laithsakka wants to merge 1 commit into
pytorch:mainfrom
laithsakka:export-D104701778

Conversation

@laithsakka
Copy link
Copy Markdown
Contributor

Summary: guard_size_oblivious is deprecated use an explicit logic.

Differential Revision: D104701778

…xir.

Summary: guard_size_oblivious is deprecated use an explicit logic.

Differential Revision: D104701778
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 12, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19516

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 4 Unrelated Failures

As of commit 14f88e9 with merge base 8020fe0 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 12, 2026

@laithsakka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104701778.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Comment thread exir/tensor.py
# u0 < u0 -> False
# u0 < u1 (no info) -> False
# u0 < 2 * u0 -> True (divisibility)
# 1 < u0 -> True (1 divides anything; unprovable equality treated optimistically)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stride of 1 will be in every tensor do we expect this to matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants