Thread method-scoped kernel registry through Program and Method (#19561)#19561
Thread method-scoped kernel registry through Program and Method (#19561)#19561JacobSzwejbka wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19561
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New Failures, 1 Cancelled Job, 4 Unrelated FailuresAs of commit 0682ab2 with merge base 8e8e957 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JacobSzwejbka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98080033. |
This PR needs a
|
…rch#19561) Summary: Certain kernels might make optimizations that are broadly optimal but sub optimal for a specific model. In those scenarios it is useful to expose a backdoor for the exception method to defer to a different implementation without forcing the root imlementation to have to handle all possible dispatches. This is just a proposal impl because things still get a little weird because ET today tends to have kernel impls get auto registered. Might need follow ups to allow generating boxed kernels separately from registering them into ETs generic kernel registry. Reviewed By: rascani Differential Revision: D98080033
c4e71f6 to
d3e5087
Compare
…rch#19561) Summary: Certain kernels might make optimizations that are broadly optimal but sub optimal for a specific model. In those scenarios it is useful to expose a backdoor for the exception method to defer to a different implementation without forcing the root imlementation to have to handle all possible dispatches. This is just a proposal impl because things still get a little weird because ET today tends to have kernel impls get auto registered. Might need follow ups to allow generating boxed kernels separately from registering them into ETs generic kernel registry. Reviewed By: rascani Differential Revision: D98080033
d3e5087 to
49b6615
Compare
…rch#19561) Summary: Certain kernels might make optimizations that are broadly optimal but sub optimal for a specific model. In those scenarios it is useful to expose a backdoor for the exception method to defer to a different implementation without forcing the root imlementation to have to handle all possible dispatches. This is just a proposal impl because things still get a little weird because ET today tends to have kernel impls get auto registered. Might need follow ups to allow generating boxed kernels separately from registering them into ETs generic kernel registry. Reviewed By: rascani Differential Revision: D98080033
49b6615 to
505fb86
Compare
…orch#19519) Summary: Expose logic for just scanning a passed in KernelRegistry. Reviewed By: rascani Differential Revision: D98079809
…rch#19561) Summary: Certain kernels might make optimizations that are broadly optimal but sub optimal for a specific model. In those scenarios it is useful to expose a backdoor for the exception method to defer to a different implementation without forcing the root imlementation to have to handle all possible dispatches. This is just a proposal impl because things still get a little weird because ET today tends to have kernel impls get auto registered. Might need follow ups to allow generating boxed kernels separately from registering them into ETs generic kernel registry. Reviewed By: rascani Differential Revision: D98080033
505fb86 to
0682ab2
Compare
Summary:
Certain kernels might make optimizations that are broadly optimal but sub optimal for a specific model. In those scenarios it is useful to expose a backdoor for the exception method to defer to a different implementation without forcing the root imlementation to have to handle all possible dispatches.
This is just a proposal impl because things still get a little weird because ET today tends to have kernel impls get auto registered. Might need follow ups to allow generating boxed kernels separately from registering them into ETs generic kernel registry.
Reviewed By: rascani
Differential Revision: D98080033