Avoid per-node GraphModule retracing in view/permute propagation - #22066
Avoid per-node GraphModule retracing in view/permute propagation#22066apullin wants to merge 1 commit into
Conversation
Summary: Batch all currently eligible view/permute propagation moves in one fixed-point scan before retracing the graph. The prior loop retraced the complete graph after every individual move, which becomes quadratic on large repeated models. The pass still retraces between fixed-point scans, before newly exposed propagation opportunities are reconsidered, and before horizontal/vertical cleanup. Differential Revision: D117110269
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22066
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 513d889 with merge base b8b5e0f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@apullin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117110269. |
This PR needs a
|
Summary:
Batch all currently eligible view/permute propagation moves in one fixed-point scan before retracing the graph. The prior loop retraced the complete graph after every individual move, which becomes quadratic on large repeated models.
The pass still retraces between fixed-point scans, before newly exposed propagation opportunities are reconsidered, and before horizontal/vertical cleanup.
Differential Revision: D117110269
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani