FROMLIST: arm64: dts: qcom: glymur: Add EVA clock controller node

[taniyadas20]

Add the device node for the EVA clock controller (evacc) for Qualcomm Glymur SoC. The EVACC provides clocks and resets to the EVA hardware block.

Link: https://lore.kernel.org/r/20260526-evacc_glymur-v1-4-b61c7755c403@oss.qualcomm.com

[qlijarvis]

🔨 Build Failure Analysis — PR #1235

PR: #1235
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26444043306

#	Error	File:Line	PR-introduced?	Root Cause
1	fatal error: dt-bindings/clock/qcom,glymur-evacc.h: No such file or directory	arch/arm64/boot/dts/qcom/glymur.dtsi:8	Yes	PR adds #include for a dt-bindings header that does not exist in the kernel tree

Verdict

1 of 1 errors is introduced by this PR. The build failure is caused by a missing dependency (dt-bindings header file).

📎 Detailed analysis: Full report

[qlijarvis]

PR #1235 — validate-patch

PR: #1235

Verdict	Issues	Detailed Report
⚠️	2	Full report

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/r/20260526-evacc_glymur-v1-4-b61c7755c403@oss.qualcomm.com
2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable
3. Upstream patch status: Cannot verify — network access restricted; manual check required to determine if ACKed / NACKed / Decision Pending
4. PR present in qcom-next: No — searched local kernel repo; commit not found in qcom-next branch

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1235 - FROMLIST: arm64: dts: qcom: glymur: Add EVA clock controller node
Upstream commit: https://lore.kernel.org/r/20260526-evacc_glymur-v1-4-b61c7755c403@oss.qualcomm.com
Verdict: ⚠️ PARTIAL (network-restricted validation)

Commit Message

Check	Status	Note
Subject matches upstream	⏭️	Cannot verify — network access restricted; lore.kernel.org unreachable
Body preserves rationale	✅	Commit body describes the EVA clock controller node addition clearly
Fixes tag present/correct	N/A	Not a bugfix; no Fixes tag expected
Authorship preserved	⏭️	FROMLIST: prefix — submitter in From: is correct; cannot verify original lore author's Signed-off-by: without fetching lore patch
Backport note (if applicable)	N/A	FROMLIST: commit — not yet merged upstream, no backport note expected

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/glymur.dtsi	⏭️	Cannot compare to lore source — network restricted

Structural Analysis (PR patch only)

What the PR adds:

• New evacc clock controller node at 0xabf0000
• Compatible string: qcom,glymur-evacc
• Clock inputs: GCC_EVA_AHB_CLK, RPMH_CXO_CLK, RPMH_CXO_CLK_A, sleep_clk
• Power domains: RPMHPD_MMCX, RPMHPD_MXC with low_svs OPPs
• Provides: #clock-cells, #reset-cells, #power-domain-cells
• Includes new header: <dt-bindings/clock/qcom,glymur-evacc.h>

Commit message hygiene:

• ✅ Prefix: FROMLIST: — correct for a patch posted to mailing list but not yet merged
• ✅ Link tag present: Link: https://lore.kernel.org/r/20260526-evacc_glymur-v1-4-b61c7755c403@oss.qualcomm.com
• ✅ Author: Taniya Das <taniya.das@oss.qualcomm.com> — matches From: and Signed-off-by:
• ✅ Subject format: follows kernel convention arm64: dts: qcom: <soc>: <description>
• ⚠️ Series context: This is patch 4 of a series (v1-4-b61c7755c403) — dependency check required: patches 1–3 must be present in the tree or PR for this to apply cleanly

Issues

• Network restriction: Cannot fetch the upstream lore patch to verify:
  • Exact diff match (hunks, line numbers, context)
  • Original author's Signed-off-by: presence (required for FROMLIST: commits)
  • Upstream patch status (ACKed / NACKed / Decision Pending)
  • Whether this is the latest revision or superseded by v2/v3
• Series dependency: This is patch 4 of a series. Patches 1–3 likely include:
  • DT binding documentation for qcom,glymur-evacc
  • Driver changes for the evacc clock controller
  • Header file dt-bindings/clock/qcom,glymur-evacc.h definitions
  • Without these, this patch will not compile or apply cleanly.

Verdict

Cannot fully validate due to network restrictions preventing lore.kernel.org access.

What can be confirmed:

• ✅ Lore link is present and correctly formatted
• ✅ Commit message structure follows kernel conventions
• ✅ FROMLIST: prefix is appropriate for a posted-but-not-merged patch
• ✅ DTS node structure appears well-formed (compatible, reg, clocks, power-domains)

What requires manual verification:

1. Fetch the lore patch manually and compare diff content line-by-line
2. Verify the original lore author's Signed-off-by: is present (required for FROMLIST:)
3. Check if patches 1–3 of the series are already in the tree or included in this PR
4. Confirm the upstream patch status (under review / accepted / needs revision)
5. Verify this is the latest revision (not superseded by v2)

Recommendation: Manually fetch the lore series with:

b4 am 20260526-evacc_glymur-v1-4-b61c7755c403@oss.qualcomm.com -o /tmp/evacc_series

Then verify:

• All 4 patches in the series are accounted for
• Diff content matches exactly
• Original author's Signed-off-by: is preserved
• No newer revision exists on the mailing list

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/r/20260526-evacc_glymur-v1-4-b61c7755c403@oss.qualcomm.com
2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable
3. Upstream patch status: Cannot verify — network access restricted; manual check required to determine if ACKed / NACKed / Decision Pending
4. PR present in qcom-next: No — searched local kernel repo; commit not found in qcom-next branch

[qlijarvis]

PR #1235 — checker-log-analyzer

PR: #1235
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26444043859

Checker	Result	Summary
Checker	Result	Summary
checkpatch	⚠️	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Build failure: missing header file
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	✅	Passed
tag-check	✅	All commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1235 - FROMLIST: arm64: dts: qcom: glymur: Add EVA clock controller node
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26444043859

Checker	Result	Summary
checkpatch	⚠️	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Build failure: missing header file
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	✅	Passed
tag-check	✅	All commits have valid FROMLIST: prefix

---

⚠️ checkpatch

Root cause: The DT compatible string qcom,glymur-evacc is not documented in a binding file.

Failure details:

Commit 548d30dce3a5 ("FROMLIST: arm64: dts: qcom: glymur: Add EVA clock controller node")
WARNING: DT compatible string "qcom,glymur-evacc" appears un-documented -- check ./Documentation/devicetree/bindings/
#33: FILE: arch/arm64/boot/dts/qcom/glymur.dtsi:5792:
+			compatible = "qcom,glymur-evacc";

548d30dce3a5eb5bcea90b32e0d66e0f2f5ff5ff total: 0 errors, 1 warnings, 0 checks, 31 lines checked

Fix: This warning indicates that the DT binding documentation for qcom,glymur-evacc should exist in Documentation/devicetree/bindings/. Since the commit references a lore link (https://lore.kernel.org/r/20260526-evacc_glymur-v1-4-b61c7755c403@oss.qualcomm.com), this is likely part of a patch series where the binding is added in an earlier patch. The warning is expected if the binding patch hasn't been merged into the base branch yet.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git df3ae9703774b70a7b7758b53498a25de9f87174..548d30dce3a5eb5bcea90b32e0d66e0f2f5ff5ff

---

❌ dtb-check

Root cause: Missing header file dt-bindings/clock/qcom,glymur-evacc.h prevents DTB compilation.

Failure details:

../arch/arm64/boot/dts/qcom/glymur.dtsi:8:10: fatal error: dt-bindings/clock/qcom,glymur-evacc.h: No such file or directory
    8 | #include <dt-bindings/clock/qcom,glymur-evacc.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [../scripts/Makefile.dtbs:140: arch/arm64/boot/dts/qcom/glymur-crd.dtb] Error 1

The patch adds #include <dt-bindings/clock/qcom,glymur-evacc.h> to glymur.dtsi:8 and uses constants from this header (e.g., clock/reset cell indices), but the header file itself is not present in the tree.

Fix: This is a dependency issue. The header file include/dt-bindings/clock/qcom,glymur-evacc.h must be added to the tree before this DTS patch can be merged. Based on the lore link in the commit message, this is patch 4 of a series (-v1-4-), and the header is likely introduced in an earlier patch of the same series.

Action required:

1. Ensure the earlier patches in the series (which add the binding YAML and the header file) are merged into the base branch first.
2. Alternatively, if this PR is intended to include the full series, add the missing header file to this PR.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur-crd.dtb

---

Verdict

2 blockers must be resolved before merge:

1. dtb-check failure (critical): The missing header file dt-bindings/clock/qcom,glymur-evacc.h prevents DTB compilation. This patch depends on earlier patches in the series that introduce the binding and header. Merge those dependencies first, or include them in this PR.

2. checkpatch warning (non-critical): The undocumented compatible string warning is expected if the binding patch hasn't been merged yet. This will resolve automatically once the binding is in the base branch.

Recommendation: Ensure the full patch series is applied in order (binding YAML → header file → DTS changes), or merge the prerequisite patches into the base branch before merging this PR.