Skip to content

FROMLIST: arm64: dts: qcom: monaco: Add GEM_NOC interconnect for adre…#1243

Open
bibekpatro wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs8300from
bibekpatro:tech/all/dt/qcs8300
Open

FROMLIST: arm64: dts: qcom: monaco: Add GEM_NOC interconnect for adre…#1243
bibekpatro wants to merge 1 commit into
qualcomm-linux:tech/all/dt/qcs8300from
bibekpatro:tech/all/dt/qcs8300

Conversation

@bibekpatro
Copy link
Copy Markdown

…no SMMU

On Monaco platforms, the Adreno SMMU requires a bandwidth vote on the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers are accessible. Without this vote, the SMMU may become unreachable, leading to intermittent probe failures and runtime issues.

Add the required interconnect to ensure reliable register access.

Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/

…no SMMU

On Monaco platforms, the Adreno SMMU requires a bandwidth vote on
the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers
are accessible. Without this vote, the SMMU may become unreachable,
leading to intermittent probe failures and runtime issues.

Add the required interconnect to ensure reliable register access.

Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, jingyiwang42, mukeshojha-linux and quic-tingweiz and removed request for a team May 26, 2026 20:50
@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1243

PR: #1243
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474370772

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during integration arch/arm64/boot/dts/qcom/Makefile No CI integration workflow attempted to merge PR with topic/tech/all/dt/qcs8300 branch, resulting in a conflict in the Makefile. The PR does not modify this file.

Verdict

This is not a compilation failure. The build failed during the pre-build integration phase due to a merge conflict in a file (Makefile) that the PR does not touch. The PR changes to monaco.dtsi merged cleanly. This is a pre-existing integration issue between topic branches, not a code error introduced by this PR.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1243

PR: #1243
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474370772

# Error File:Line PR-introduced? Root Cause
1 Git merge conflict arch/arm64/boot/dts/qcom/Makefile No Conflict between integration baseline and topic branch during CI merge workflow; PR does not modify this file

Verdict

0 of 1 errors are introduced by this PR; 1 is pre-existing. The build never reached compilation. The PR's actual changes (monaco.dtsi) merged cleanly.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

PR #1243 — validate-patch

PR: #1243

Verdict Issues Detailed Report
N/A 3 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/ (v2 series cover letter)
  2. Lore link matches PR commits: Cannot verify — network access restricted; manual fetch required
  3. Upstream patch status: Cannot verify — network access restricted; date (2026-05-26) suggests very recent posting
  4. PR present in qcom-next: No — searched qcom-next branch, interconnect property not present in monaco.dtsi adreno SMMU node
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1243 - FROMLIST: arm64: dts: qcom: monaco: Add GEM_NOC interconnect for adreno SMMU
Upstream commit: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
Verdict: ⏭️ SKIPPED (network restricted)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network access restricted
Body preserves rationale Clear problem statement and fix description present
Fixes tag present/correct N/A No Fixes tag (new feature addition)
Authorship preserved ⏭️ Cannot verify lore author - network restricted; FROMLIST: allows submitter in From:
Backport note (if applicable) N/A FROMLIST: prefix indicates pending upstream patch

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco.dtsi Clean 2-line addition of interconnect property to adreno SMMU node

Issues

  • Network access restricted: Cannot fetch lore.kernel.org patch to verify diff faithfulness, upstream status, or authorship
  • Commit message structure: Well-formed with clear rationale, proper Link: tag, and Signed-off-by
  • Prefix usage: FROMLIST: is appropriate for a patch posted to mailing list but not yet merged upstream

Verdict

Cannot complete full validation due to network restrictions. Based on local analysis only:

  • Commit message is well-structured with clear problem/solution description
  • Link: tag properly formatted and points to lore.kernel.org v2 series
  • Diff is clean and focused (2-line addition)
  • FROMLIST: prefix is correctly used for pending upstream patches

Recommendation: Manual verification required - reviewer should fetch the lore patch and verify:

  1. Diff content matches the linked lore patch exactly
  2. Original author's Signed-off-by is preserved (FROMLIST: allows different From:)
  3. Upstream patch status (ACKed/NACKed/Pending)

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/ (v2 series cover letter)
  2. Lore link matches PR commits: Cannot verify — network access restricted; manual fetch required
  3. Upstream patch status: Cannot verify — network access restricted; date (2026-05-26) suggests very recent posting
  4. PR present in qcom-next: No — searched qcom-next branch, interconnect property not present in monaco.dtsi adreno SMMU node

@qlijarvis
Copy link
Copy Markdown

PR #1243 — checker-log-analyzer

PR: #1243
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474370941

Checker Result Summary
Checker Result Summary
checkpatch Merge conflict - checker did not run
dt-binding-check Merge conflict - checker did not run
dtb-check Merge conflict - checker did not run
sparse-check Merge conflict - checker did not run
check-uapi-headers Merge conflict - checker did not run
check-patch-compliance Merge conflict - checker did not run
tag-check N/A Target branch is qcom-next - prefix check not required

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1243 - FROMLIST: arm64: dts: qcom: monaco: Add GEM_NOC interconnect for adreno SMMU
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474370941

Checker Result Summary
checkpatch Merge conflict - checker did not run
dt-binding-check Merge conflict - checker did not run
dtb-check Merge conflict - checker did not run
sparse-check Merge conflict - checker did not run
check-uapi-headers Merge conflict - checker did not run
check-patch-compliance Merge conflict - checker did not run
tag-check N/A Target branch is qcom-next - prefix check not required

❌ CI Infrastructure Issue — Merge Conflict

Root cause: All checker jobs failed during the CI merge preparation phase before any actual checks could run. The CI workflow attempts to merge the PR branch with topic branch topic/tech/all/dt/qcs8300 on top of baseline qcom-next (commit df3ae9703774), but encounters a merge conflict in arch/arm64/boot/dts/qcom/Makefile.

Failure details:

** Merging topic branch: topic/tech/all/dt/qcs8300
Auto-merging arch/arm64/boot/dts/qcom/Makefile
CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/Makefile
Auto-merging arch/arm64/boot/dts/qcom/monaco.dtsi
Automatic merge failed; fix conflicts and then commit the result.
Merge failed, manual merge
##[error]Process completed with exit code 1.

This failure occurred identically across all six checker jobs:

  • checkpatch
  • dt-binding-check
  • dtb-check
  • sparse-check
  • check-uapi-headers
  • check-patch-compliance

Analysis:

This is not a patch quality issue. The PR commit itself is well-formed:

  • ✅ Has valid FROMLIST: prefix
  • ✅ Has upstream Link: tag pointing to lore.kernel.org
  • ✅ Has proper Signed-off-by: tag
  • ✅ Modifies only DTS file (arch/arm64/boot/dts/qcom/monaco.dtsi)
  • ✅ Does not touch arch/arm64/boot/dts/qcom/Makefile

The conflict arises from the CI workflow's attempt to integrate multiple topic branches together. The PR branch modifies monaco.dtsi cleanly, but when the CI tries to merge it with topic/tech/all/dt/qcs8300, there's a conflict in the Makefile (likely due to concurrent additions of new DTB targets).

Fix: This is a CI workflow/integration issue that requires one of the following actions:

  1. Rebase the topic branch topic/tech/all/dt/qcs8300 onto the latest qcom-next baseline to resolve the Makefile conflict upstream.

  2. Re-trigger the CI after the topic branch conflict is resolved.

  3. Adjust the CI workflow to handle merge conflicts more gracefully or to test PR branches independently before integration.

No changes needed to the PR patch itself. The patch is correctly formatted and the code change is valid.

Reproduce locally:

# Clone the kernel repo
git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout df3ae9703774b70a7b7758b53498a25de9f87174

# Fetch the topic branch
git fetch origin tech/all/dt/qcs8300:topic/tech/all/dt/qcs8300

# Try to merge (will reproduce the conflict)
git merge topic/tech/all/dt/qcs8300

# Check the conflict
git status

Verdict

CI infrastructure issue — no patch changes required.

The PR commit is properly formatted with correct prefix (FROMLIST:), upstream link, and sign-off. The failure is due to a merge conflict between topic branches in the CI integration workflow, not a defect in the submitted patch. The conflict occurs in arch/arm64/boot/dts/qcom/Makefile, which the PR does not modify.

Recommended action: Resolve the merge conflict in the topic/tech/all/dt/qcs8300 branch or adjust the CI workflow, then re-trigger the checker run. The patch itself is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants