FROMLIST: arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adre…

[bibekpatro]

…no SMMU

On Lemans platforms, the Adreno SMMU requires a bandwidth vote on the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers are accessible. Without this vote, the SMMU may become unreachable, leading to intermittent probe failures and runtime issues.

Add the required interconnect to ensure reliable register access.

Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/

[qlijarvis]

PR #1244 — validate-patch

PR: #1244

Verdict	Issues	Detailed Report
N/A	3	Full report

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/ (v2 series cover letter)
2. Lore link matches PR commits: Cannot verify — network access to lore.kernel.org is restricted
3. Upstream patch status: Cannot verify — network access required to check mailing list thread and git trees
4. PR present in qcom-next: No — interconnects property not present in adreno_smmu node in origin/qcom-next

Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1244 - FROMLIST: arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU
Upstream commit: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
Verdict: ⏭️ CANNOT VERIFY (network restricted)

Commit Message

Check	Status	Note
Subject matches upstream	⏭️	Cannot fetch lore patch (network restricted)
Body preserves rationale	✅	Clear description of issue and fix
Fixes tag present/correct	N/A	No Fixes tag (new feature addition)
Authorship preserved	⏭️	FROMLIST: submitter in From: is correct; cannot verify lore author's Signed-off-by without upstream patch
Backport note (if applicable)	N/A	FROMLIST prefix used (not yet merged upstream)

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/lemans.dtsi	⏭️	Cannot compare to upstream (network restricted); adds interconnects property to adreno_smmu node

Issues

• Network restriction: Cannot fetch upstream lore patch to verify diff faithfulness, author attribution, or upstream acceptance status
• Commit message structure: Well-formed with clear rationale, proper Link: tag, and Signed-off-by
• FROMLIST prefix: Correctly used for patches posted to mailing list but not yet merged

Verdict

Cannot complete full validation due to network restrictions preventing lore.kernel.org access. The commit message structure is correct for a FROMLIST patch. Manual verification required: (1) fetch the lore patch and compare diff content, (2) verify the lore author's Signed-off-by is present, (3) check upstream acceptance status.

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/ (v2 series cover letter)
2. Lore link matches PR commits: Cannot verify — network access to lore.kernel.org is restricted
3. Upstream patch status: Cannot verify — network access required to check mailing list thread and git trees
4. PR present in qcom-next: No — interconnects property not present in adreno_smmu node in origin/qcom-next

[qlijarvis]

PR #1244 — checker-log-analyzer

PR: #1244
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474464709

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	interconnects property not allowed in arm,smmu.yaml schema
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Link verification failed (patch not yet posted to lore)
tag-check	✅	Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1244 - FROMLIST: arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474464709
Target branch: tech/all/dt/qcs9100

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	interconnects property not allowed in arm,smmu.yaml schema
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Link verification failed (patch not yet posted to lore)
tag-check	✅	Subject has valid FROMLIST: prefix

---

❌ dtb-check

Root cause: The arm,smmu.yaml binding schema does not declare interconnects as an allowed property for qcom,sa8775p-smmu-500.

Failure details:

lemans-evk.dtb: iommu@3da0000 (qcom,sa8775p-smmu-500): 'interconnects' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml#
lemans-evk-el2.dtb: iommu@3da0000 (qcom,sa8775p-smmu-500): 'interconnects' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml#
lemans-camx-el2.dtb: iommu@3da0000 (qcom,sa8775p-smmu-500): 'interconnects' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml#

Analysis:
The patch adds interconnects property to the Adreno SMMU node in lemans.dtsi:4456. However, the upstream Documentation/devicetree/bindings/iommu/arm,smmu.yaml binding does not include interconnects in its allowed properties. The schema uses unevaluatedProperties: false or additionalProperties: false, which rejects any undeclared properties.

Fix:
This requires an upstream binding update to allow interconnects for Qualcomm SMMU variants. Two approaches:

1. Preferred (upstream first): Submit a binding patch to arm,smmu.yaml adding interconnects support for Qualcomm SMMU compatibles:

   allOf:
     - if:
         properties:
           compatible:
             contains:
               enum:
                 - qcom,sa8775p-smmu-500
                 - qcom,sc7280-smmu-500
                 # ... other qcom variants
       then:
         properties:
           interconnects:
             maxItems: 1
           interconnect-names:
             maxItems: 1

2. Workaround (if binding update is pending): Add a Qualcomm-specific SMMU binding that extends arm,smmu.yaml and declares interconnects support.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-evk.dtb

---

❌ check-patch-compliance

Root cause: The lore.kernel.org link in the commit message points to a message that does not exist yet (future date: 2026-05-26).

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/

Analysis:
The commit includes:

Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/

The message-ID 20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com indicates a date of May 26, 2026, but the patch has not been posted to the mailing list yet. The b4 tool cannot fetch a non-existent message, causing the checker to fail.

Fix:

1. Post the patch series to the upstream mailing list first (linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org).
2. After posting, update the commit message with the actual lore.kernel.org URL from the archive.
3. Force-push the updated commit to the PR branch.

Alternatively, if this is a pre-posting PR for internal review:

• Remove the Link: line temporarily until the patch is posted upstream.
• Note: This will still fail check-patch-compliance because FROMLIST: prefix requires a valid Link: tag.

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
# Expected: HTTP 404 or "Message not found"

---

Verdict

2 blockers must be fixed before merge:

1. dtb-check failure: The interconnects property is not allowed by the upstream arm,smmu.yaml binding. This requires either:

   • An upstream binding patch to allow interconnects for Qualcomm SMMU variants, OR
   • A Qualcomm-specific SMMU binding extension.

2. check-patch-compliance failure: The lore.kernel.org link points to a non-existent message. The patch must be posted upstream first, then the commit message updated with the actual lore URL.

Recommendation: Post the patch series upstream (including the binding update for interconnects support), then update this PR with the correct lore links after the patches appear in the archive.