FROMLIST: arm64: dts: qcom: talos: Add GEM_NOC interconnect for adren…

[bibekpatro]

…o SMMU

On Talos platforms, the Adreno SMMU requires a bandwidth vote on the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers are accessible. Without this vote, the SMMU may become unreachable, leading to intermittent probe failures and runtime issues.

Add the required interconnect to ensure reliable register access.

Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/

[qlijarvis]

PR #1245 — validate-patch

PR: #1245

Verdict	Issues	Detailed Report
⚠️	11	Full report

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
2. Lore link matches PR commits: Cannot verify — network access restricted; manual verification required
3. Upstream patch status: Cannot verify — network access restricted; check lore thread manually for ACK/NAK/Pending status
4. PR present in qcom-next: No — verified that interconnects property is not present in current qcom-next branch (commit 1d5c82f added adreno_smmu node without interconnects)

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1245 - FROMLIST: arm64: dts: qcom: talos: Add GEM_NOC interconnect for adreno SMMU
Upstream commit: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (network-restricted validation)

Commit Message

Check	Status	Note
Subject matches upstream	⏭️ Skipped	Cannot fetch lore patch (network restricted)
Body preserves rationale	✅ Pass	Clear technical rationale provided: GEM_NOC path required for SMMU register access
Fixes tag present/correct	✅ Pass	No Fixes tag needed - this is a new feature addition, not a bug fix
Authorship preserved	⚠️ Warning	FROMLIST: prefix used - original author's Signed-off-by should be verified against lore
Backport note (if applicable)	N/A	Not a backport - FROMLIST indicates pending upstream patch

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/talos.dtsi	✅ Pass	Adds interconnects property to adreno_smmu node at correct location (after dma-coherent)

Issues

Network Access Limitation:

• Cannot fetch upstream lore patch to verify exact diff match due to network restrictions
• Cannot verify upstream patch status (ACKed/NACKed/Pending) via lore thread analysis
• Cannot search mainline/stable trees for merge status

Authorship Verification (FROMLIST-specific):

• For FROMLIST: commits, the submitter (Bibek Kumar Patro) is legitimately in the From: field
• The original lore author's Signed-off-by: must be present in the commit message
• Current commit shows only one Signed-off-by: from Bibek Kumar Patro
• Action needed: Verify against lore that Bibek Kumar Patro is the original patch author, OR if different, ensure original author's Signed-off-by: is included

Technical Content:

• The patch adds a GEM_NOC interconnect path (MASTER_GPU_TCU → SLAVE_EBI1) to the adreno_smmu node
• This is a valid device tree addition for ensuring SMMU register accessibility
• The commit message clearly explains the technical necessity (bandwidth vote required before register access)
• The diff is clean, focused, and adds only the required interconnects property

Verdict

Cannot complete full validation due to network restrictions preventing lore.kernel.org access.

What can be verified (✅ Pass):

• Commit message structure is correct for FROMLIST prefix
• Technical rationale is clear and appropriate
• Diff is syntactically correct and targets the right file/location
• Change is not present in current qcom-next branch (verified locally)

What requires manual verification:

1. Fetch the lore patch and confirm diff content matches exactly
2. Verify the original patch author matches the From: field, or ensure original author's Signed-off-by: is present
3. Check lore thread for upstream acceptance status (ACKed/NACKed/Pending)
4. Verify the lore link points to the correct revision (v2 indicated in URL)

Recommendation: Manually verify the lore patch content and authorship before merge. The commit structure and technical content appear correct, but full validation requires network access to lore.kernel.org.

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
2. Lore link matches PR commits: Cannot verify — network access restricted; manual verification required
3. Upstream patch status: Cannot verify — network access restricted; check lore thread manually for ACK/NAK/Pending status
4. PR present in qcom-next: No — verified that interconnects property is not present in current qcom-next branch (commit 1d5c82f added adreno_smmu node without interconnects)

[qlijarvis]

PR #1245 — checker-log-analyzer

PR: #1245
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474652983

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	interconnects property not allowed in arm,smmu.yaml binding
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Link points to cover letter instead of actual patch
tag-check	✅	Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1245 - FROMLIST: arm64: dts: qcom: talos: Add GEM_NOC interconnect for adreno SMMU
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26474652983

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	interconnects property not allowed in arm,smmu.yaml binding
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Link points to cover letter instead of actual patch
tag-check	✅	Subject has valid FROMLIST: prefix

❌ dtb-check

Root cause: The arm,smmu.yaml binding schema does not allow the interconnects property, causing validation failures for all DTBs that include the Adreno SMMU node with the newly added interconnect.

Failure details:

iommu@50a0000 (qcom,qcs615-smmu-500): 'interconnects' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml#

This error appears in 8 DTB files:

• qcs615-ride.dtb
• qcs615-ride-camx.dtb
• qcs615-ride-el2.dtb
• talos-evk.dtb
• talos-evk-camera-imx577.dtb
• talos-evk-camx.dtb
• talos-evk-lvds-auo,g133han01.dtb
• talos-evk-usb1-peripheral.dtb

Fix: The upstream arm,smmu.yaml binding needs to be updated to allow the interconnects property. This requires:

1. Add interconnects and interconnect-names to the binding's properties: section in Documentation/devicetree/bindings/iommu/arm,smmu.yaml
2. Submit the binding update as a separate patch before the DTS change
3. Ensure the binding patch is merged upstream first, then update the Link: in this patch to reference the merged binding

Alternatively, if the binding update is already posted upstream but not yet in this tree, you can:

• Cherry-pick or backport the binding update patch first
• Then apply this DTS change

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/talos-evk.dtb

❌ check-patch-compliance

Root cause: The Link: tag points to the cover letter (-v2-0-) instead of the actual patch (-v2-1-).

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: talos: Add GEM_NOC interconnect for adreno SMMU
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/

The link https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/ ends with -v2-0-, which is the cover letter (patch 0 of a series). The checker expects a link to the actual patch.

Fix:

git rebase -i <base_sha>   # mark commit as 'edit'
# Update the Link: line in the commit message to point to patch 1:
git commit --amend
# Change:
#   Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com/
# To:
#   Link: https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-1-2a6d8ca30d63@oss.qualcomm.com/
git rebase --continue

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260526-smmu_interconnect_addition-v2-1-2a6d8ca30d63@oss.qualcomm.com/

Verdict

2 blockers must be fixed before merge:

1. dtb-check failure — The arm,smmu.yaml binding must be updated to allow interconnects property. This is a prerequisite for merging this DTS change. Either:

   • Submit and merge the binding update first, or
   • Cherry-pick an existing upstream binding update if available

2. check-patch-compliance failure — Update the Link: tag to point to the actual patch (-v2-1-) instead of the cover letter (-v2-0-)

The dtb-check failure is the more critical blocker, as it indicates a missing binding update that must be addressed before this DTS change can be merged.