Skip to content

arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators#549

Open
tingguoc wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
tingguoc:qcom-6.18.y
Open

arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators#549
tingguoc wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
tingguoc:qcom-6.18.y

Conversation

@tingguoc
Copy link
Copy Markdown

@tingguoc tingguoc commented May 8, 2026

Add the missing LDOs and supply parents so that camera sensor drivers can request the required power rails.

L1M supplies the IMX688 AON core domain (DVDD). It is fed by S5J and supports an output range of 1056-1200 mV.

L2M supplies the IMX766 core domain (DVDD). It is fed by S5J and supports an output range of 1152-1200 mV.

L3M supplies the IMX766 analog domain and OV sensor I/O (AVDD2, DOVDD). It is fed by S4C and is fixed at 1808 mV.

L5M supplies the IMX766 VCM. It is fed by BOB1 and is fixed at 2960 mV.

L6M supplies the IMX688 AON analog domain (AVDD2). It is fed by S4C and is fixed at 1808 mV.

@tingguoc tingguoc requested review from a team, knaveen-qc, quicAspratap and yijiyang May 8, 2026 02:20
Copy link
Copy Markdown

@shashim-quic shashim-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submit the change upstream and bring it as FROMLIST.
Add Link: to commit log.

Add the missing LDOs and supply parents so that camera sensor drivers
can request the required power rails.

L1M supplies the IMX688 AON core domain (DVDD). It is fed by S5J
and supports an output range of 1056-1200 mV.

L2M supplies the IMX766 core domain (DVDD). It is fed by S5J and
supports an output range of 1152-1200 mV.

L3M supplies the IMX766 analog domain and OV sensor I/O (AVDD2,
DOVDD). It is fed by S4C and is fixed at 1808 mV.

L5M supplies the IMX766 VCM. It is fed by BOB1 and is fixed at
2960 mV.

L6M supplies the IMX688 AON analog domain (AVDD2). It is fed by
S4C and is fixed at 1808 mV.

L7M supplies the camera analog domain (AVDD). It is fed by BOB1
and is fixed at 2912 mV.

Signed-off-by: Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qcomlnxci qcomlnxci requested a review from a team May 27, 2026 09:50
@qlijarvis
Copy link
Copy Markdown

PR #549 — validate-patch

PR: #549

Verdict Issues Detailed Report
2 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — cannot determine without lore link
  4. PR present in qcom-next: Not checked — validation cannot proceed without upstream reference

Recommendation:

  • If this patch is based on upstream work or a mailing list posting, add Link: https://lore.kernel.org/r/<message-id> to the commit message with the appropriate prefix (FROMLIST:, UPSTREAM:, or BACKPORT:).
  • If this is vendor-specific board enablement with no upstream equivalent, add the QCLINUX: prefix to the subject line: QCLINUX: arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators (#549)
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No upstream link to compare
Body preserves rationale No upstream link to compare
Fixes tag present/correct N/A Not a fix commit
Authorship preserved No upstream link to compare
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi Cannot validate without upstream reference

Issues

  • No lore.kernel.org link found: The commit message contains no Link: tag pointing to lore.kernel.org, and no vendor prefix (QCLINUX:, PENDING:, WORKAROUND:) is present to indicate this is intentionally vendor-only.
  • Missing commit prefix: If this is vendor-specific board enablement, it should use the QCLINUX: prefix. If it's based on an upstream patch, it should include a lore link with FROMLIST:, UPSTREAM:, or BACKPORT: prefix.

Verdict

Cannot validate patch integrity without an upstream reference. Add a lore.kernel.org link if this is based on upstream work, or use the QCLINUX: prefix if this is vendor-only board enablement.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — cannot determine without lore link
  4. PR present in qcom-next: Not checked — validation cannot proceed without upstream reference

Recommendation:

  • If this patch is based on upstream work or a mailing list posting, add Link: https://lore.kernel.org/r/<message-id> to the commit message with the appropriate prefix (FROMLIST:, UPSTREAM:, or BACKPORT:).
  • If this is vendor-specific board enablement with no upstream equivalent, add the QCLINUX: prefix to the subject line: QCLINUX: arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators

@qlijarvis
Copy link
Copy Markdown

PR #549 — checker-log-analyzer

PR: #549
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26503939922

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance Missing subject prefix
tag-check Missing subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #549 - arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26503939922
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance Missing subject prefix
tag-check Missing subject prefix (mandatory for qcom-6.18.y)

❌ check-patch-compliance

Root cause: Commit subject line does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators
Commit summary does not start with a required prefix

The commit subject is:

arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators

This checker requires one of the following prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.

Fix:

  1. Determine the correct prefix based on the patch origin:

    • If posted to lore.kernel.org but not yet merged → use FROMLIST:
    • If in a maintainer git tree → use FROMGIT:
    • If merged into Linus's mainline tree → use UPSTREAM:
    • If backported with modifications → use BACKPORT:
    • If vendor-only with no upstream → use QCLINUX: (note: this will still fail the checker, but is acceptable for vendor-only changes)
  2. Amend the commit:

    git rebase -i b0d4b962afa7132279e908f9237476494f9208a8
    # mark commit 22c07ec286f0 as 'edit'
    git commit --amend -m "FROMLIST: arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators"
    # keep the rest of the commit message body unchanged
    git rebase --continue
  3. If using FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:, also add a Link: tag in the commit body pointing to the lore.kernel.org URL.

Reproduce locally:

cd /path/to/kernel
git log --oneline b0d4b962afa7..22c07ec286f0
# Verify subject starts with FROMLIST:/FROMGIT:/UPSTREAM:/BACKPORT:

❌ tag-check

Root cause: Subject prefix is mandatory for all commits targeting branches other than qcom-next or qcom-next-staging.

Failure details:

Commit 22c07ec286f0 ("arm64: dts: qcom: purwa-iot-som: Add PM8010 camera PMIC regulators") targets branch qcom-6.18.y and does not have a required prefix.

All commits merged into qcom-6.18.y must start with one of:

  • FROMLIST: — patch posted to mailing list
  • FROMGIT: — patch from maintainer tree
  • UPSTREAM: — patch merged into mainline
  • BACKPORT: — upstream patch with modifications
  • QCLINUX: — vendor-only change
  • PENDING: — work-in-progress
  • WORKAROUND: — temporary fix

Fix:

Same as check-patch-compliance above — add the appropriate prefix to the commit subject.

Reproduce locally:

git log b0d4b962afa7..22c07ec286f0 --format="%H %s" | \
  grep -vE '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'
# Any output indicates commits missing a prefix

Verdict

1 blocker must be fixed before merge: Add a subject prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, or QCLINUX:) to the commit. If the patch has an upstream equivalent, also add a Link: tag in the commit body.

@tingguoc
Copy link
Copy Markdown
Author

CRs-Fixed: 4552442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants