Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 184 additions & 0 deletions Documentation/devicetree/bindings/connector/pcie-m2-e-connector.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,184 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/connector/pcie-m2-e-connector.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: PCIe M.2 Mechanical Key E Connector

maintainers:
- Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

description:
A PCIe M.2 E connector node represents a physical PCIe M.2 Mechanical Key E
connector. Mechanical Key E connectors are used to connect Wireless
Connectivity devices including combinations of Wi-Fi, BT, NFC to the host
machine over interfaces like PCIe/SDIO, USB/UART+PCM, and I2C.

properties:
compatible:
const: pcie-m2-e-connector

vpcie3v3-supply:
description: A phandle to the regulator for 3.3v supply.

vpcie1v8-supply:
description: A phandle to the regulator for VIO 1.8v supply.

i2c-parent:
$ref: /schemas/types.yaml#/definitions/phandle
description: I2C interface

clocks:
description: 32.768 KHz Suspend Clock (SUSCLK) input from the host system to
the M.2 card. Refer, PCI Express M.2 Specification r4.0, sec 3.1.12.1 for
more details.
maxItems: 1

w-disable1-gpios:
description: GPIO output to W_DISABLE1# signal. This signal is used by the
host system to disable WiFi radio in the M.2 card. Refer, PCI Express M.2
Specification r4.0, sec 3.1.12.3 for more details.
maxItems: 1

w-disable2-gpios:
description: GPIO output to W_DISABLE2# signal. This signal is used by the
host system to disable BT radio in the M.2 card. Refer, PCI Express M.2
Specification r4.0, sec 3.1.12.3 for more details.
maxItems: 1

viocfg-gpios:
description: GPIO input to IO voltage configuration (VIO_CFG) signal. The
card drives this signal to indicate to the host system whether the card
supports an independent IO voltage domain for sideband signals. Refer,
PCI Express M.2 Specification r4.0, sec 3.1.15.1 for more details.
maxItems: 1

uart-wake-gpios:
description: GPIO input to UART_WAKE# signal. The card asserts this signal
to wake the host system and initiate UART interface communication. Refer,
PCI Express M.2 Specification r4.0, sec 3.1.8.1 for more details.
maxItems: 1

sdio-wake-gpios:
description: GPIO input to SDIO_WAKE# signal. The card asserts this signal
to wake the host system and initiate SDIO interface communication. Refer,
PCI Express M.2 Specification r4.0, sec 3.1.7 for more details.
maxItems: 1

sdio-reset-gpios:
description: GPIO output to SDIO_RESET# signal. This signal is used by the
host system to reset SDIO interface of the M.2 card. Refer, PCI Express
M.2 Specification r4.0, sec 3.1.7 for more details.
maxItems: 1

vendor-porta-gpios:
description: GPIO for the first vendor specific signal (VENDOR_PORTA). This
signal's functionality is defined by the card manufacturer and may be
used for proprietary features. Refer the card vendor's documentation for
details.
maxItems: 1

vendor-portb-gpios:
description: GPIO for the second vendor specific signal (VENDOR_PORTB). This
signal's functionality is defined by the card manufacturer and may be
used for proprietary features. Refer the card vendor's documentation for
details.
maxItems: 1

vendor-portc-gpios:
description: GPIO for the third vendor specific signal (VENDOR_PORTC). This
signal's functionality is defined by the card manufacturer and may be
used for proprietary features. Refer the card vendor's documentation for
details.
maxItems: 1

ports:
$ref: /schemas/graph.yaml#/properties/ports
description: OF graph bindings modeling the interfaces exposed on the
connector. Since a single connector can have multiple interfaces, every
interface has an assigned OF graph port number as described below.

properties:
port@0:
$ref: /schemas/graph.yaml#/properties/port
description: PCIe interface for Wi-Fi

port@1:
$ref: /schemas/graph.yaml#/properties/port
description: SDIO interface for Wi-Fi

port@2:
$ref: /schemas/graph.yaml#/properties/port
description: USB 2.0 interface for BT

port@3:
$ref: /schemas/graph.yaml#/properties/port
description: UART interface for BT

port@4:
$ref: /schemas/graph.yaml#/properties/port
description: PCM/I2S interface

anyOf:
- anyOf:
- required:
- port@0
- required:
- port@1
- anyOf:
- required:
- port@2
- required:
- port@3

required:
- compatible
- vpcie3v3-supply

additionalProperties: false

examples:
# PCI M.2 Key E connector for Wi-Fi/BT with PCIe/UART interfaces
- |
#include <dt-bindings/gpio/gpio.h>

connector {
compatible = "pcie-m2-e-connector";
vpcie3v3-supply = <&vreg_wcn_3p3>;
vpcie1v8-supply = <&vreg_l15b_1p8>;
i2c-parent = <&i2c0>;
w-disable1-gpios = <&tlmm 115 GPIO_ACTIVE_LOW>;
w-disable2-gpios = <&tlmm 116 GPIO_ACTIVE_LOW>;
viocfg-gpios = <&tlmm 117 GPIO_ACTIVE_HIGH>;
uart-wake-gpios = <&tlmm 118 GPIO_ACTIVE_LOW>;
sdio-wake-gpios = <&tlmm 119 GPIO_ACTIVE_LOW>;
sdio-reset-gpios = <&tlmm 120 GPIO_ACTIVE_LOW>;

ports {
#address-cells = <1>;
#size-cells = <0>;

port@0 {
reg = <0>;
#address-cells = <1>;
#size-cells = <0>;

endpoint@0 {
reg = <0>;
remote-endpoint = <&pcie4_port0_ep>;
};
};

port@3 {
reg = <3>;
#address-cells = <1>;
#size-cells = <0>;

endpoint@0 {
reg = <0>;
remote-endpoint = <&uart14_ep>;
};
};
};
};
145 changes: 145 additions & 0 deletions Documentation/devicetree/bindings/connector/pcie-m2-m-connector.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/connector/pcie-m2-m-connector.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: PCIe M.2 Mechanical Key M Connector

maintainers:
- Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

description:
A PCIe M.2 M connector node represents a physical PCIe M.2 Mechanical Key M
connector. The Mechanical Key M connectors are used to connect SSDs to the
host system over PCIe/SATA interfaces. These connectors also offer optional
interfaces like USB, SMBus.

properties:
compatible:
const: pcie-m2-m-connector

vpcie3v3-supply:
description: A phandle to the regulator for 3.3v supply.

vpcie1v8-supply:
description: A phandle to the regulator for VIO 1.8v supply.

ports:
$ref: /schemas/graph.yaml#/properties/ports
description: OF graph bindings modeling the interfaces exposed on the
connector. Since a single connector can have multiple interfaces, every
interface has an assigned OF graph port number as described below.

properties:
port@0:
$ref: /schemas/graph.yaml#/properties/port
description: PCIe interface

port@1:
$ref: /schemas/graph.yaml#/properties/port
description: SATA interface

port@2:
$ref: /schemas/graph.yaml#/properties/port
description: USB 2.0 interface

anyOf:
- required:
- port@0
- required:
- port@1

i2c-parent:
$ref: /schemas/types.yaml#/definitions/phandle
description: I2C interface

clocks:
description: 32.768 KHz Suspend Clock (SUSCLK) input from the host system to
the M.2 card. Refer, PCI Express M.2 Specification r4.0, sec 3.1.12.1 for
more details.
maxItems: 1

pedet-gpios:
description: GPIO input to PEDET signal. This signal is used by the host
systems to determine the communication protocol that the M.2 card uses;
SATA signaling (low) or PCIe signaling (high). Refer, PCI Express M.2
Specification r4.0, sec 3.3.4.2 for more details.
maxItems: 1

viocfg-gpios:
description: GPIO input to IO voltage configuration (VIO_CFG) signal. This
signal is used by the host systems to determine whether the card supports
an independent IO voltage domain for the sideband signals or not. Refer,
PCI Express M.2 Specification r4.0, sec 3.1.15.1 for more details.
maxItems: 1

pwrdis-gpios:
description: GPIO output to Power Disable (PWRDIS) signal. This signal is
used by the host system to disable power on the M.2 card. Refer, PCI
Express M.2 Specification r4.0, sec 3.3.5.2 for more details.
maxItems: 1

pln-gpios:
description: GPIO output to Power Loss Notification (PLN#) signal. This
signal is used by the host system to notify the M.2 card that the power
loss event is about to occur. Refer, PCI Express M.2 Specification r4.0,
sec 3.2.17.1 for more details.
maxItems: 1

plas3-gpios:
description: GPIO input to Power Loss Acknowledge (PLA_S3#) signal. This
signal is used by the host system to receive the acknowledgment of the M.2
card's preparation for power loss.
maxItems: 1

required:
- compatible
- vpcie3v3-supply

additionalProperties: false

examples:
# PCI M.2 Key M connector for SSDs with PCIe interface
- |
#include <dt-bindings/gpio/gpio.h>

connector {
compatible = "pcie-m2-m-connector";
vpcie3v3-supply = <&vreg_nvme>;
i2c-parent = <&i2c0>;
pedet-gpios = <&tlmm 95 GPIO_ACTIVE_HIGH>;
viocfg-gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>;
pwrdis-gpios = <&tlmm 97 GPIO_ACTIVE_HIGH>;
pln-gpios = <&tlmm 98 GPIO_ACTIVE_LOW>;
plas3-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;

ports {
#address-cells = <1>;
#size-cells = <0>;

port@0 {
#address-cells = <1>;
#size-cells = <0>;

reg = <0>;

endpoint@0 {
reg = <0>;
remote-endpoint = <&pcie6_port0_ep>;
};
};

port@2 {
#address-cells = <1>;
#size-cells = <0>;

reg = <2>;

endpoint@0 {
reg = <0>;
remote-endpoint = <&usb_hs_ep>;
};
};
};
};
3 changes: 3 additions & 0 deletions Documentation/devicetree/bindings/serial/serial.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ properties:
description:
TX FIFO threshold configuration (in bytes).

port:
$ref: /schemas/graph.yaml#/properties/port

patternProperties:
"^(bluetooth|bluetooth-gnss|embedded-controller|gnss|gps|mcu|onewire)$":
if:
Expand Down
8 changes: 8 additions & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -20511,6 +20511,14 @@ F: Documentation/driver-api/pwrseq.rst
F: drivers/power/sequencing/
F: include/linux/pwrseq/

PCIE M.2 POWER SEQUENCING
M: Manivannan Sadhasivam <mani@kernel.org>
L: linux-pci@vger.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/connector/pcie-m2-e-connector.yaml
F: Documentation/devicetree/bindings/connector/pcie-m2-m-connector.yaml
F: drivers/power/sequencing/pwrseq-pcie-m2.c

POWER STATE COORDINATION INTERFACE (PSCI)
M: Mark Rutland <mark.rutland@arm.com>
M: Lorenzo Pieralisi <lpieralisi@kernel.org>
Expand Down
1 change: 1 addition & 0 deletions drivers/pci/pwrctrl/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ config PCI_PWRCTRL_PWRSEQ

config PCI_PWRCTRL_GENERIC
tristate "Generic PCI Power Control driver for PCI slots"
select POWER_SEQUENCING
select PCI_PWRCTRL
help
Say Y here to enable the generic PCI Power Control driver to control
Expand Down
6 changes: 3 additions & 3 deletions drivers/pci/pwrctrl/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,10 @@ static int pci_pwrctrl_create_device(struct device_node *np,

/*
* Check whether the pwrctrl device really needs to be created or not.
* This is decided based on at least one of the power supplies being
* defined in the devicetree node of the device.
* This is decided based on at least one of the power supplies defined
* in the devicetree node of the device or the graph property.
*/
if (!of_pci_supply_present(np)) {
if (!of_pci_supply_present(np) && !of_graph_is_present(np)) {
dev_dbg(parent, "Skipping OF node: %s\n", np->name);
return 0;
}
Expand Down
Loading