Skip to content

Update TSENS thermal zone#615

Open
dmantre wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
dmantre:purwa-highertj
Open

Update TSENS thermal zone#615
dmantre wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
dmantre:purwa-highertj

Conversation

@dmantre
Copy link
Copy Markdown

@dmantre dmantre commented May 26, 2026

Purwa IOT boards support a different thermal junction temperature specification compared to the base Purwa platform due to package level differences.

Update the passive trip thresholds to 105°C to align with the higher temperature specification.

CRs-Fixed: 4468304

@dmantre dmantre requested review from a team, Komal-Bajaj, knaveen-qc and quicAspratap May 26, 2026 12:53
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis
Copy link
Copy Markdown

PR #615 — validate-patch

PR: #615

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network access to lore.kernel.org is blocked; unable to fetch upstream patch for comparison
  3. Upstream patch status: Cannot verify - network restrictions prevent fetching lore thread to check for merge/NAK/pending signals or searching mainline/stable trees
  4. PR present in qcom-next: No - searched qcom-next history for purwa-iot-evk thermal zone updates; no matching commit found (last activity on this file was Bluetooth/camss/UFS/SDC2 changes)

Recommendation for manual review:

  • Verify the lore patch author matches the Signed-off-by: in this commit (FROMLIST rule: original author's SOB must be present)
  • Confirm the diff content is faithful to the lore posting
  • Check lore thread for any review feedback or newer revisions (v2, v3, etc.)
  • Verify upstream acceptance status before merging
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #615 - FROMLIST: arm64: dts: qcom: purwa-iot-evk: Update TSENS thermal zone
Upstream commit: https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
Verdict: ⚠️ PARTIAL (network restrictions prevented full upstream verification)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network access to lore.kernel.org blocked
Body preserves rationale Clear description of thermal spec difference and 105°C threshold
Fixes tag present/correct N/A Not a bug fix - new thermal configuration
Authorship preserved ⏭️ FROMLIST: submitter in From: is expected; cannot verify lore author's Signed-off-by without upstream fetch
Backport note (if applicable) N/A FROMLIST prefix used correctly for posted-but-not-merged patch

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-iot-evk.dts Clean addition of 4 thermal zone overrides (thermal_gpuss_0-3), each setting trip-point0 to 105000 (105°C)

Issues

  • Network restriction: Cannot fetch upstream lore patch to verify diff faithfulness, commit message accuracy, or check for newer revisions
  • FROMLIST authorship rule: For FROMLIST commits, the submitter (Gaurav Kohli) is legitimately in From: field. The original lore author's Signed-off-by: must be present in the commit message - cannot verify without fetching the lore patch, but the current commit only has one Signed-off-by: (the submitter's), which suggests either (a) Gaurav is the original author, or (b) the original author's SOB is missing if this was someone else's patch

Verdict

Cannot complete full validation due to network restrictions. The commit structure is well-formed (proper FROMLIST prefix, lore link present, clear rationale), but upstream diff comparison and authorship chain verification require lore.kernel.org access.

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify - network access to lore.kernel.org is blocked; unable to fetch upstream patch for comparison
  3. Upstream patch status: Cannot verify - network restrictions prevent fetching lore thread to check for merge/NAK/pending signals or searching mainline/stable trees
  4. PR present in qcom-next: No - searched qcom-next history for purwa-iot-evk thermal zone updates; no matching commit found (last activity on this file was Bluetooth/camss/UFS/SDC2 changes)

Recommendation for manual review:

  • Verify the lore patch author matches the Signed-off-by: in this commit (FROMLIST rule: original author's SOB must be present)
  • Confirm the diff content is faithful to the lore posting
  • Check lore thread for any review feedback or newer revisions (v2, v3, etc.)
  • Verify upstream acceptance status before merging

@qlijarvis
Copy link
Copy Markdown

PR #615 — checker-log-analyzer

PR: #615
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26449268618

Checker Result Summary
Checker Result Summary
checkpatch 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check FATAL: Label or path not found
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No C/H files changed
check-patch-compliance FROMLIST prefix + Link present
tag-check Subject has valid FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST commit targeting qcom-6.18.y (not qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #615 - FROMLIST: arm64: dts: qcom: purwa-iot-evk: Update TSENS thermal zone
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26449268618
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check FATAL: Label or path not found
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No C/H files changed
check-patch-compliance FROMLIST prefix + Link present
tag-check Subject has valid FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST commit targeting qcom-6.18.y (not qcom-next)

❌ dtb-check — FATAL BUILD ERROR

Root cause: The patch references thermal zone labels (&thermal_gpuss_0, &thermal_gpuss_1, &thermal_gpuss_2, &thermal_gpuss_3) that do not exist in the device tree at the target branch qcom-6.18.y.

Failure details:

Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1332.1-17 Label or path thermal_gpuss_0 not found
Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1340.1-17 Label or path thermal_gpuss_1 not found
Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1348.1-17 Label or path thermal_gpuss_2 not found
Error: ../arch/arm64/boot/dts/qcom/purwa-iot-evk.dts:1356.1-17 Label or path thermal_gpuss_3 not found
FATAL ERROR: Syntax error parsing input tree
make[4]: *** [../scripts/Makefile.dtbs:132: arch/arm64/boot/dts/qcom/purwa-iot-evk.dtb] Error 1

The patch attempts to override thermal zone nodes using phandle references (&thermal_gpuss_0 through &thermal_gpuss_3), but these labels are not defined in the base device tree files included by purwa-iot-evk.dts.

Fix:

Option 1 (Recommended): Ensure the prerequisite patch that defines these thermal zone labels is merged into qcom-6.18.y first, then rebase this PR.

Option 2: If the thermal zones exist but with different label names, update the patch to use the correct labels present in qcom-6.18.y.

Option 3: If the thermal zones don't exist at all in qcom-6.18.y, this patch cannot be applied to this branch. It should either:

  • Target a different branch where the thermal zones are defined, OR
  • Be preceded by a patch series that adds the thermal zone definitions

Reproduce locally:

git checkout qcom-6.18.y
git cherry-pick a68507c5b7f681cb91cf7969db77075fb81b63b9
make -j$(nproc) O=out defconfig
make -j$(nproc) O=out arch/arm64/boot/dts/qcom/purwa-iot-evk.dtb

To investigate which thermal zone labels exist:

git checkout qcom-6.18.y
grep -r "thermal_gpuss" arch/arm64/boot/dts/qcom/

⚠️ qcom-next-check

Observation: This is a FROMLIST: commit (posted upstream at https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com) targeting the qcom-6.18.y branch.

Policy note: FROMLIST: and UPSTREAM: commits typically target qcom-next or qcom-next-staging first, then flow to release branches. Directly targeting a release branch (qcom-6.18.y) with a FROMLIST: commit may indicate:

  • A backport scenario (should use BACKPORT: prefix if modified)
  • A cherry-pick from qcom-next (verify the commit exists there first)
  • An out-of-order merge (the commit should land in qcom-next first)

Recommendation: Verify this commit is already in qcom-next before merging to qcom-6.18.y. If it's a backport with modifications, use the BACKPORT: prefix instead.


Verdict

❌ BLOCKER: Cannot merge — DTB build fails.

The patch references thermal zone labels that do not exist in the qcom-6.18.y branch, causing a fatal device tree compilation error. This must be resolved before the PR can be merged:

  1. Immediate action: Identify why the thermal zone labels are missing in qcom-6.18.y
  2. Resolution path: Either merge the prerequisite patches that define these labels first, or retarget this PR to a branch where the labels exist
  3. Verification: Confirm the DTB builds successfully after the fix

@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

dmantre and others added 2 commits May 28, 2026 19:40
Add labels to GPU thermal zone node.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Purwa IOT boards support a different thermal junction temperature
specification compared to the base Purwa platform due to package
level differences.

Update the passive trip thresholds to 105°C to align with the higher
temperature specification.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis
Copy link
Copy Markdown

PR #615 — validate-patch

PR: #615

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; no vendor/internal prefix present
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — no upstream posting; appears to be local infrastructure for Commit 2
  4. PR present in qcom-next: No — not found in qcom-next branch

Commit 2/2: FROMLIST: arm64: dts: qcom: purwa-iot-evk: Update TSENS thermal zone

Upstream commit: https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
Verdict: ⚠️ PARTIAL (cannot verify lore content due to network restrictions; structural validation only)

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #615
Commits: 2 commits analyzed


Commit 1/2: arm64: dts: qcom: purwa: Add labels to GPU thermal zone node

Upstream commit: N/A
Verdict:FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream link provided
Body preserves rationale ⚠️ Minimal description; no explanation of why labels are needed
Fixes tag present/correct N/A Not a fix
Authorship preserved N/A No upstream to compare
Backport note (if applicable) N/A Not a backport
Commit prefix Missing required prefix (should be QCLINUX: or PENDING:)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa.dtsi Adds labels thermal_gpuss_0 through thermal_gpuss_3 to thermal zone nodes

Issues

  1. No lore link found — This commit has no UPSTREAM:, FROMLIST:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, or WORKAROUND: prefix, and no lore.kernel.org link in the commit message.
  2. Missing commit prefix — Per the validate-patch skill, commits without a lore link must use QCLINUX:, PENDING:, or WORKAROUND: prefix to indicate they are vendor-only or work-in-progress.
  3. Insufficient commit message — The body only repeats the subject line. It should explain why these labels are being added (i.e., to enable thermal zone overrides in board-specific DTS files).
  4. Dependency for Commit 2 — This commit exists solely to support Commit 2, which references these labels. The two commits should be ordered correctly (Commit 1 before Commit 2), which they are.

Verdict

FAIL — No lore.kernel.org link was found in the commit message, and no vendor/internal prefix (QCLINUX:, PENDING:, WORKAROUND:) is present. This skill only validates patches against a lore.kernel.org source.

Recommendation

Option 1 (Recommended): If this change is a prerequisite for the FROMLIST patch and is not intended for upstream submission on its own, add the PENDING: prefix:

PENDING: arm64: dts: qcom: purwa: Add labels to GPU thermal zone node

Add labels to GPU thermal zone nodes to enable board-specific
thermal threshold overrides in purwa-iot-evk.dts.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>

Option 2: If this change should be posted upstream as part of the same series as the FROMLIST patch, add the FROMLIST: prefix and include the lore link to the cover letter or the first patch in the series.

Option 3: If this is vendor-only infrastructure with no upstream intent, use QCLINUX: prefix.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; no vendor/internal prefix present
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — no upstream posting; appears to be local infrastructure for Commit 2
  4. PR present in qcom-next: No — not found in qcom-next branch

Commit 2/2: FROMLIST: arm64: dts: qcom: purwa-iot-evk: Update TSENS thermal zone

Upstream commit: https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
Verdict: ⚠️ PARTIAL (cannot verify lore content due to network restrictions; structural validation only)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot fetch lore patch (network restricted)
Body preserves rationale Clear explanation of thermal spec difference and 105°C threshold
Fixes tag present/correct N/A Not a fix
Authorship preserved ⏭️ Cannot verify against lore (FROMLIST: submitter may differ from author)
Backport note (if applicable) N/A Not a backport
Commit prefix Correct FROMLIST: prefix with lore link

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-iot-evk.dts Overrides trip-point0 temperature to 105000 (105°C) for 4 GPU thermal zones

Dependency Check

Dependency Status Notes
Commit 1 (thermal zone labels) Required labels thermal_gpuss_0 through thermal_gpuss_3 are defined in Commit 1

Issues

  1. Cannot verify lore content — Network access is restricted; cannot fetch the upstream lore patch to compare diff content, commit message, or authorship. Structural validation only.
  2. Dependency on Commit 1 — This commit references &thermal_gpuss_0, &thermal_gpuss_1, &thermal_gpuss_2, and &thermal_gpuss_3, which are labels added in Commit 1. If Commit 1 is not merged first, this commit will fail to apply or build.

Verdict

PARTIAL — Commit structure is correct (proper FROMLIST: prefix, lore link present, clear commit message, correct dependency ordering). However, cannot verify that the PR diff matches the lore patch due to network restrictions.

Recommendation

Manual verification required:

  1. Fetch the lore patch: curl -L "https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com/raw"
  2. Compare the diff content to ensure the PR patch is faithful to the lore posting.
  3. Verify that the lore patch author matches the From: field or is present in Signed-off-by: (for FROMLIST, the submitter may differ from the original author).
  4. Check the lore thread for acceptance/rejection signals (see references/upstream-status.md in the validate-patch skill).

Dependency note: Commit 1 must be resolved (either merged with a proper prefix, or posted upstream as part of the same series) before this commit can be safely merged.

Upstream Patch Status

⏭️ Cannot verify — Network access restricted; unable to fetch lore thread or check mainline/stable trees for merge status.

Manual check required:

# Check if merged into mainline
git log --oneline --grep="Update TSENS thermal zone" torvalds/linux
# Check lore thread for acceptance signals
b4 mbox -c -C -o /tmp 20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
grep -i "applied\|queued\|merged\|Reviewed-by\|Acked-by" /tmp/*.mbx

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/r/20260416-purwa_high_tj-v1-1-b538f98d42da@oss.qualcomm.com
  2. Lore link matches PR commits: ⏭️ Cannot verify — network restricted; manual comparison required
  3. Upstream patch status: ⏭️ Cannot verify — network restricted; check lore thread and mainline manually
  4. PR present in qcom-next: No — not found in qcom-next branch (searched by subject and file history)

Overall PR Assessment

Critical Issues

  1. Commit 1 has no lore link and no vendor prefix — Must be corrected before merge. Recommended: add PENDING: prefix and improve commit message to explain the purpose (enabling board-specific thermal overrides).
  2. Cannot verify Commit 2 against lore — Network restrictions prevent fetching the upstream patch. Manual verification is required to ensure the PR diff matches the lore posting.

Dependency Chain

Correct ordering: Commit 1 (adds labels) → Commit 2 (uses labels)
⚠️ Blocker: Commit 1 must be resolved before Commit 2 can be safely merged.

Recommended Actions

  1. For Commit 1: Add PENDING: prefix and expand commit message:

    PENDING: arm64: dts: qcom: purwa: Add labels to GPU thermal zone node
    
    Add labels to GPU thermal zone nodes (thermal_gpuss_0 through
    thermal_gpuss_3) to enable board-specific thermal threshold
    overrides in purwa-iot-evk.dts.
    
    Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
    
  2. For Commit 2: Manually verify against lore:

    • Fetch lore patch and compare diff content
    • Check lore thread for acceptance/rejection/review status
    • Verify authorship (for FROMLIST, original author must be in Signed-off-by:)
  3. Alternative approach: If both commits are part of the same upstream series, post Commit 1 to lore as well, then update both commits to use FROMLIST: prefix with appropriate lore links.

@qlijarvis
Copy link
Copy Markdown

PR #615 — checker-log-analyzer

PR: #615
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26580755419

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance Missing prefix on commit 9d0ff29
tag-check Missing prefix on commit 9d0ff29

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #615 - Add labels to GPU thermal zone and update TSENS thermal zone
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26580755419
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance Missing prefix on commit 9d0ff29
tag-check Missing prefix on commit 9d0ff29

❌ check-patch-compliance

Root cause: Commit 9d0ff29296c5 ("arm64: dts: qcom: purwa: Add labels to GPU thermal zone node") does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: purwa: Add labels to GPU thermal zone node
Commit summary does not start with a required prefix

Fix: Add an appropriate prefix to the commit subject. Since this appears to be a vendor-specific change adding labels for internal use, use QCLINUX: prefix:

git rebase -i a1f6d71a69b0   # mark commit 9d0ff29 as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: purwa: Add labels to GPU thermal zone node

Add labels to GPU thermal zone node.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>"
git rebase --continue

Prefix selection guide:

  • FROMLIST: - if posted to lore.kernel.org (requires Link: tag)
  • FROMGIT: - if taken from a maintainer git tree
  • UPSTREAM: - if merged into Linus's mainline
  • BACKPORT: - if backported with modifications
  • QCLINUX: - vendor-only change (recommended for this commit)

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base a1f6d71a69b09d36f9af071759877e6d33b572fa \
  --head c8635509c80d8a686a35b4c86abcc6b0aee43777

❌ tag-check

Root cause: Target branch qcom-6.18.y requires all commits to have a subject-line prefix tag. Commit 9d0ff29296c5 is missing this mandatory prefix.

Failure details:

Commit 9d0ff29296c5 ("arm64: dts: qcom: purwa: Add labels to GPU thermal zone node")
Subject line: "arm64: dts: qcom: purwa: Add labels to GPU thermal zone node"
Missing prefix - does not start with: FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Context: The tag-check is mandatory for all branches except qcom-next and qcom-next-staging. Since this PR targets qcom-6.18.y, every commit must carry a prefix tag.

Fix: Same as check-patch-compliance above - add QCLINUX: prefix to the first commit.

Note: The second commit c8635509c80d ("FROMLIST: arm64: dts: qcom: purwa-iot-evk: Update TSENS thermal zone") already has the correct FROMLIST: prefix and includes a Link: tag, so it passes both checks.


Verdict

1 blocker to fix: Add QCLINUX: prefix to commit 9d0ff29296c5. Once fixed, all checkers will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants