Skip to content

Revert "firmware: qcom: scm: Allow QSEECOM on Glymur CRD"#617

Open
sgaud-quic wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
sgaud-quic:qcom-next
Open

Revert "firmware: qcom: scm: Allow QSEECOM on Glymur CRD"#617
sgaud-quic wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
sgaud-quic:qcom-next

Conversation

@sgaud-quic
Copy link
Copy Markdown
Contributor

Adding glymur-crd to the QSEECOM allowlist causes qcom_scm to fully initialize at early boot, which sets up uefisecapp and registers EFI variable operations. This makes efi_has_tpm2() succeed by reading the LoaderTpm2ActivePcrBanks EFI variable, satisfying ConditionSecurity=tpm2 in systemd.

As a result, systemd activates tpm2.target which unconditionally waits for /dev/tpm0 and /dev/tpmrm0.
systemd waits the full 90-second timeout for each of the two TPM device units, pushing total boot time beyond 2 minutes.

Revert until TPM driver in place and /dev/tpm0 node is created.

This reverts commit 87a1698.

Adding glymur-crd to the QSEECOM allowlist causes qcom_scm to fully
initialize at early boot, which sets up uefisecapp and registers EFI
variable operations. This makes efi_has_tpm2() succeed by reading the
LoaderTpm2ActivePcrBanks EFI variable, satisfying ConditionSecurity=tpm2
in systemd.

As a result, systemd activates tpm2.target which unconditionally waits
for /dev/tpm0 and /dev/tpmrm0.
systemd waits the full 90-second timeout for each of the two
TPM device units, pushing total boot time beyond 2 minutes.

Revert until TPM driver in place and /dev/tpm0 node is created.

This reverts commit 87a1698.

Signed-off-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com>
@qswat-orbit-external
Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Copy link
Copy Markdown

@shashim-quic shashim-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now as a workaround till formal fix is delivered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants