camxlib-hamoa: Update to the 1.0.25 revision#2284
Conversation
add support to og0va1b sensor for Hamoa Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
lumag
left a comment
There was a problem hiding this comment.
add support to og0va1b sensor for Hamoa
Why is it being performed only for Hamoa? Can we have platform-independent sensors descriptions so that all platforms get updates at the same time? (okay, maybe all except Kodiak).
The og0va1b sensor is applicable only to the Hamoa target, which is why this change is being made exclusively for the Hamoa target. |
What prevents people using it with any other target? |
Test Results 103 files ± 0 633 suites +1 6h 28m 8s ⏱️ + 1h 29m 58s For more details on these failures, see this check. Results for commit d9dd83f. ± Comparison against base commit 5716703. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
The OG0VA1B sensor is currently supported only on the Hamoa EVK with a custom daughter card. While the driver can be retained for use across other targets, including it globally would add it to every target package, unnecessarily increasing the device footprint. Until the sensor is enabled through the kernel device tree for additional targets, it is preferable to keep the driver limited to the specific target to minimize the overall file count. |
What prevents our customers from using the sensor with any other platform? You are just replying that there are no devboards using that sensor.
Why do we care about file count at all? |
In addition to increasing the file count, other targets may have different hardware configurations such as sensor-to-PHY mapping, varying cell indices (slot IDs), and target-specific tuning binaries. As a result, this target-specific driver may not be compatible with other targets. |
sensor-to-PHY mappings should depend on the board wiring. It is of no concern for the platform support. Could you please point out the list of sensors / target combinations that are supported by CamX? |
Target platforms and their supported sensors, along with unique Slot IDs, PHY laneconfig, and tuning settings: Kodiak: IMX577, OV9282, IMX686, AR0231(GMSL) |
|
Is |
Yes. there are two CSI Ports having 2&4 lanes configuration respectively. IMX577 2L requires different mode setting as per the CSI lane count. |
Sorry, I was asking about the bare |
The IMX577 driver currently supports only 4L modes. The addition of 2L mode was requested specifically for Talos, as it is currently the only device with a 22-pin 2L CSI connector. |
Thanks. So what is the difference between IMX577 for Kodiak, Lemans, Talos and Hamoa? Also, if the customer uses Hamoa SoM and wants to use a 2-lane connector for IMX577, does it require an update on the CamX side? |
The IMX577 driver for Kodiak, Lemans, Talos, and Hamoa uses a separate Chromatix name for each target to load specific tuning, has individual slot-ids, and may be slightly tuned for each target. |
Why are there different names and different slots? It's the same sensor, being attached to a different base. Do we ISP-specific params or are we just adding the different name for the sake of keeping it different? Why are the slot-ids different too? For the tuning, is it 'might be' or 'is'? If it is just 'might be', we should drop that 'might', at least for the generic market / IoT. |
|
The complexity of supporting diffferent sensors on different platforms doesn't seem (to me, sorry) to warrant possible gain. |
@gkhose-qipl please improve your git commit message saying that for now it is platform specific. |
@ricardosalveti , |
Quick example (AI-produced): Anything better than just 'add support for foo on bar' would do it. |
add support to og0va1b sensor for Hamoa