Skip to content

Switch from pull_request_target to pull_request trigger#135

Merged
simonbeaudoin0935 merged 6 commits intomainfrom
development
Apr 13, 2026
Merged

Switch from pull_request_target to pull_request trigger#135
simonbeaudoin0935 merged 6 commits intomainfrom
development

Conversation

@simonbeaudoin0935
Copy link
Copy Markdown
Contributor

Change PR trigger pull_request_target -> pull_request

In order to avoid leaking secrets by remote code execution coming
from public PRs, the PR workflow trigger has been changed back to
on: pull_request. This makes that secrets outside of the GITHUB_TOKEN
cannot be used.

Therefore, the GITHUB_TOKEN is used all over to fetch the container.

keerthi-go
keerthi-go previously approved these changes Apr 10, 2026
In order to avoid leaking secrets by remote code execution coming
from public PRs, the PR workflow trigger has been changed back to
on: pull_request. This makes that secrets outside of the GITHUB_TOKEN
cannot be used.

Therefore, the GITHUB_TOKEN is used all over to fetch the container.

Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
Signed-off-by: Simon Beaudoin <sbeaudoi@qti.qualcomm.com>
@simonbeaudoin0935 simonbeaudoin0935 merged commit 4e989a4 into main Apr 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants