build-dtb-image: add --metadata-dir to use local qcom-dtb-metadata#166
Open
GuanquanTian wants to merge 1 commit into
Open
build-dtb-image: add --metadata-dir to use local qcom-dtb-metadata#166GuanquanTian wants to merge 1 commit into
GuanquanTian wants to merge 1 commit into
Conversation
Allow callers to point at a pre-cloned qcom-dtb-metadata directory instead of fetching it during the build. Skips the clone and the 'git reset --hard' so local edits to the .its file or qcom-metadata.dts are preserved across rebuilds. Mutually exclusive with --metadata-commit (which would discard local changes). Validates that the directory contains the required ITS file and qcom-metadata.dts before proceeding. Signed-off-by: guanquan <guanquan@qti.qualcomm.com>
GuanquanTian
requested review from
bjordiscollaku,
keerthi-go,
simonbeaudoin0935 and
vishwasudupa
as code owners
Contributor
|
@GuanquanTian dtb-image building tool in qcom-build-utils is deprecated; please reference to this moving forward. Tool now resides in the same repository as dtb metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--metadata-diroption tobuild-dtb-image.shto point at a pre-clonedqcom-dtb-metadatadirectory instead of fetching it during the buildgit reset --hard, preserving local edits to.itsandqcom-metadata.dtsacross rebuilds--metadata-commit(which would discard local changes); validates required files exist before proceeding