tests/integration: add partitions.conf validator#119
Closed
GuanquanTian wants to merge 2 commits into
Closed
Conversation
Rename the second uefi_dtb_a partition to uefi_dtb_b to match the A/B slot naming used elsewhere in this layout (dtb_a/dtb_b, uefisecapp_a/ uefisecapp_b, etc.). Signed-off-by: guanquan <guanquan@qti.qualcomm.com>
Catch duplicate partition names and missing required fields in platforms/*/*/partitions.conf at integration-test time. Wire it into the existing make integration target so PRs that introduce a duplicate fail CI before reaching review. The check is intentionally limited to duplicate --name and missing --name/--size — duplicate --type-guid within a LUN is widely (and intentionally) used across A/B and primary/backup partitions, so flagging it would generate noise without catching real bugs. platforms/glymur-crd/spinor/partitions.conf is allowlisted because it contains a pre-existing duplicate SYSFW_VERSION entry that requires a separate fix. Signed-off-by: guanquan <guanquan@qti.qualcomm.com>
GuanquanTian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a validator that catches duplicate partition names and missing required
fields in
platforms/*/*/partitions.confat integration-test time, wired intomake integrationso PRs introducing the kind of bug fixed in #118 fail CIbefore reaching review.
The check is scoped to:
--namewithin the same physical partition (LUN) — strict--partitionline missing--nameor--size— strictplatforms/glymur-crd/spinor/partitions.confis allowlisted because itcontains a pre-existing duplicate
SYSFW_VERSIONentry that needs aseparate fix.