Skip to content

[qcom-next] arm: dts: talos: Disable SD card controller#71

Open
balajiselvanathan wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
balajiselvanathan:talos_sd_qn
Open

[qcom-next] arm: dts: talos: Disable SD card controller#71
balajiselvanathan wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
balajiselvanathan:talos_sd_qn

Conversation

@balajiselvanathan
Copy link
Copy Markdown

The Talos EVK does not have SD card support. So, disable the sdhc_2 node in the U-Boot device tree to prevent unnecessary initialization attempts and eliminate boot warnings.

The Talos EVK does not have SD card support. So, disable the
sdhc_2 node in the U-Boot device tree to prevent unnecessary
initialization attempts and eliminate boot warnings.

Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
@b49020
Copy link
Copy Markdown
Member

b49020 commented May 25, 2026

@balajiselvanathan can you check why the Linux DT enabled it in first place if it's not supported? I guess we might be missing something.

@balajiselvanathan
Copy link
Copy Markdown
Author

Hi Sumit, I meant in uboot sd card is not yet supported.

@b49020
Copy link
Copy Markdown
Member

b49020 commented May 26, 2026

Hi Sumit, I meant in uboot sd card is not yet supported.

I suppose only clk settings might be missing like you did for Lemans. Can you rather properly fix it?

@balajiselvanathan
Copy link
Copy Markdown
Author

Hi Sumit, I meant in uboot sd card is not yet supported.

I suppose only clk settings might be missing like you did for Lemans. Can you rather properly fix it?

I had added the clk settings, but getting this warning log during boot:
"Warning: RCG ... stuck at off " for SDCC2_APPS_CLK's set_rate. Upon debugging, found that it is setting UPDATE bit (bit 0) of GCC_SDCC1_APPS_CMD_RCGR reg (after configuring GCC_SDCC1_APPS_CFG_RCGR reg), but hw is not clearing the set bit, leading to timeout and "stuck at off" warning log. So had assumed that the PLLs to the RCG are not enabled.

@b49020
Copy link
Copy Markdown
Member

b49020 commented May 27, 2026

Hi Sumit, I meant in uboot sd card is not yet supported.

I suppose only clk settings might be missing like you did for Lemans. Can you rather properly fix it?

I had added the clk settings, but getting this warning log during boot: "Warning: RCG ... stuck at off " for SDCC2_APPS_CLK's set_rate. Upon debugging, found that it is setting UPDATE bit (bit 0) of GCC_SDCC1_APPS_CMD_RCGR reg (after configuring GCC_SDCC1_APPS_CFG_RCGR reg), but hw is not clearing the set bit, leading to timeout and "stuck at off" warning log. So had assumed that the PLLs to the RCG are not enabled.

Let's have a proper fix for the SD clocks instead of a DT workaround. The warning can be ignored by the user as it's not functional currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants